[Commits] [wesnoth/wesnoth] 8b32fc: Attempt to fix listbox scrollbar position after co...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 8b32fc20abd935e1354627b85ec6808ee38cad2d
      https://github.com/wesnoth/wesnoth/commit/8b32fc20abd935e1354627b85ec6808ee38cad2d
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-01-22 (Fri, 22 Jan 2016)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/scrollbar_container.cpp
    M src/gui/widgets/scrollbar_container.hpp

  Log Message:
  -----------
  Attempt to fix listbox scrollbar position after content changes.

Proviously, if a row was added/removed from a listbox, the scrolling
position of the listbox would be reset to 0. The expected behaviour is
that the visible part of the list does not change, this means that the
position is increased by the added space if the space was inserted
before the visible area, othewise it shouldn't be increased.

Unforunateley the code that adds/removes new rows does not know where
the extra space was inserted/removed because this is not calculated
until the next draw which calls layout_children(). So this doesn't work
very well, even after this commit.

Will try to fix this for treeviews later which might be easier because
treeviews don't use the tgenterator class and specially don't support
sorting of its elements.

We might want to revert the listbox.cpp/hpp part of this commit later
in case it doesn't work.


  Commit: 58b769192efd0907fef7d0b37b1d1ddf1a04e11a
      https://github.com/wesnoth/wesnoth/commit/58b769192efd0907fef7d0b37b1d1ddf1a04e11a
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-01-22 (Fri, 22 Jan 2016)

  Changed paths:
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/tree_view_node.cpp
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  fix gui2 treeviews resetting position when items expand


  Commit: 7e6d7d4099b4fe008354daccede5d1091977b626
      https://github.com/wesnoth/wesnoth/commit/7e6d7d4099b4fe008354daccede5d1091977b626
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-01-22 (Fri, 22 Jan 2016)

  Changed paths:
    M src/gui/widgets/tree_view_node.cpp
    M src/gui/widgets/tree_view_node.hpp

  Log Message:
  -----------
  make treeviws accept toggle_panels too

previously they only accepted toggle buttons.


  Commit: d90d76be4df3e3fe8e17451519d1b664c24bf51b
      https://github.com/wesnoth/wesnoth/commit/d90d76be4df3e3fe8e17451519d1b664c24bf51b
  Author: gfgtdf <f492343 at rmqkr.net>
  Date:   2016-01-22 (Fri, 22 Jan 2016)

  Changed paths:
    M src/gui/widgets/combobox.cpp
    M src/gui/widgets/combobox.hpp

  Log Message:
  -----------
  remove _tclickable form combobox

this confused the lua gui2 code which checks for tclickabe first and
then for tselectable so combobox was treated as a tclickable.


Compare: https://github.com/wesnoth/wesnoth/compare/9d12141ab368...d90d76be4df3