[Commits] [wesnoth/wesnoth] 61ccf2: WIP: some refactoring of event handling w/ celticm...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 61ccf2fc1623d4effea9360ef5e8940faf1db387
      https://github.com/wesnoth/wesnoth/commit/61ccf2fc1623d4effea9360ef5e8940faf1db387
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-07-14 (Thu, 14 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp

  Log Message:
  -----------
  WIP: some refactoring of event handling w/ celticminstrel


  Commit: fb02c3442f4cb61f228430720f27a76ba8b25344
      https://github.com/wesnoth/wesnoth/commit/fb02c3442f4cb61f228430720f27a76ba8b25344
  Author: Andreas Löf <andreas at alternating.net>
  Date:   2016-07-14 (Thu, 14 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp

  Log Message:
  -----------
  Merge branch 'event_handling_fixes' of https://github.com/Vultraz/wesnoth into Vultraz-event_handling_fixes


  Commit: 90b6b58aa43ea58dc0b4cb3b6f45b01e6ffc1a8a
      https://github.com/wesnoth/wesnoth/commit/90b6b58aa43ea58dc0b4cb3b6f45b01e6ffc1a8a
  Author: Andreas Löf <andreas at alternating.net>
  Date:   2016-07-14 (Thu, 14 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp

  Log Message:
  -----------
  Fix crashes in the focus cycling code.

This ensures that the focus_handler is correctly initialised and
that cycle_focus() iterates over the current handlers correctly.


  Commit: a399a0071711691abc0aabe1ff22048516f47d00
      https://github.com/wesnoth/wesnoth/commit/a399a0071711691abc0aabe1ff22048516f47d00
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-07-15 (Fri, 15 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp

  Log Message:
  -----------
  Use emplace_back when adding new event_contexts member

Thanks to celticminstrel for the suggestion.


  Commit: 75632003efef78b1d2fe9f47c6a7e4dabc47de22
      https://github.com/wesnoth/wesnoth/commit/75632003efef78b1d2fe9f47c6a7e4dabc47de22
  Author: Andreas Löf <andreas at alternating.net>
  Date:   2016-07-17 (Sun, 17 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp
    M src/preferences.cpp

  Log Message:
  -----------
  Add a destructor to the context class.

This adds a destructor to the context class to ensure that any joined
event_handlers leave the context before it is deallocated.
It also changes the preferences to explicitly leave the global event
context as it is destroyed instead of when the event handler is
destroyed during _exit().
Also replace std::list.splice with push_back and erase(iterator) in
an attempt to avoid compile errors on older versions of gcc.


  Commit: 6964aa2ba7aaee99823c9bdd7b3fc40ba8d9c5eb
      https://github.com/wesnoth/wesnoth/commit/6964aa2ba7aaee99823c9bdd7b3fc40ba8d9c5eb
  Author: Andreas Löf <andreas at alternating.net>
  Date:   2016-07-17 (Sun, 17 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp

  Log Message:
  -----------
  Change const_iterator to iterator in an attempt to appease travis.


  Commit: 516daccbba373716fafd0acc58e224e1b927ac14
      https://github.com/wesnoth/wesnoth/commit/516daccbba373716fafd0acc58e224e1b927ac14
  Author: Andreas Löf <andreas at alternating.net>
  Date:   2016-07-17 (Sun, 17 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Move the global event context onto the general event queue.

This moves the global event context onto the general event queue
and creates it through RAII instead.


  Commit: 501eb6074391f87bdfe5d670ef77450465e15499
      https://github.com/wesnoth/wesnoth/commit/501eb6074391f87bdfe5d670ef77450465e15499
  Author: Andreas Löf <andreas at alternating.net>
  Date:   2016-07-17 (Sun, 17 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp

  Log Message:
  -----------
  Fix crash in context destructor

This fixes a crash that was seen when the context destructor was calling
either leave or leave_global while iterating over the list. The current iterator
handle would be invalidated and further calls to it would return invalid values.


  Commit: 9550c3636ba826991ef9e23a0ba7dc2ad4d9ac7a
      https://github.com/wesnoth/wesnoth/commit/9550c3636ba826991ef9e23a0ba7dc2ad4d9ac7a
  Author: Andreas Löf <andreas at alternating.net>
  Date:   2016-07-17 (Sun, 17 Jul 2016)

  Changed paths:
    M src/events.cpp

  Log Message:
  -----------
  Ensure that focus handling stays the same as before the fix


  Commit: 5e7d558228ec664681fd3df0906eab9138dca62b
      https://github.com/wesnoth/wesnoth/commit/5e7d558228ec664681fd3df0906eab9138dca62b
  Author: Andreas <andreas at alternating.net>
  Date:   2016-07-18 (Mon, 18 Jul 2016)

  Changed paths:
    M src/events.cpp
    M src/events.hpp
    M src/preferences.cpp
    M src/wesnoth.cpp

  Log Message:
  -----------
  Merge pull request #696 from wesnoth/Vultraz-event_handling_fixes

Refactored event contexts to use lists instead of vectors


Compare: https://github.com/wesnoth/wesnoth/compare/2d7d6a0dde2a...5e7d558228ec