[Commits] [wesnoth/wesnoth] 5bb6aa: L Fix bugs and tidy up a bit

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5bb6aa55366883daa21652208931ab128fad1906
      https://github.com/wesnoth/wesnoth/commit/5bb6aa55366883daa21652208931ab128fad1906
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2016-07-16 (Sat, 16 Jul 2016)

  Changed paths:
    M data/campaigns/Liberty/scenarios/01_The_Raid.cfg
    M data/campaigns/Liberty/scenarios/03_A_Strategy_Of_Hope.cfg
    M data/campaigns/Liberty/scenarios/04_Unlawful_Orders.cfg
    M data/campaigns/Liberty/scenarios/05_Hide_and_Seek.cfg
    M data/campaigns/Liberty/scenarios/07_The_Hunters.cfg
    M data/campaigns/Liberty/scenarios/08_Glory.cfg
    M data/campaigns/Liberty/utils/utils.cfg

  Log Message:
  -----------
  L Fix bugs and tidy up a bit

Bugs:
S02: Use role= for roles, not speaker=
S05: Misplaced ai_algorithm
S08: No constant FOREVER, use 99999

Cleanup:
S01, S07: [if] requires [then]
S01, S05, S07, S08: remove macro artifacts
S07, S08: remove variable artifacts
S04, S08: remove dead  code
utils: Remove unused macros


  Commit: 3818fe232687ce3d1d336c565f31a1de3e1af02c
      https://github.com/wesnoth/wesnoth/commit/3818fe232687ce3d1d336c565f31a1de3e1af02c
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2016-07-16 (Sat, 16 Jul 2016)

  Changed paths:
    M data/campaigns/Liberty/scenarios/08_Glory.cfg

  Log Message:
  -----------
  L Illogical conversation

Choosing Baldras for the role cause him to see the riders and ask who they are. Baldras already has an alternate line for this case, use it.


  Commit: dad9d8f6c8cf2679c5389a2f5fd888e29153b0c2
      https://github.com/wesnoth/wesnoth/commit/dad9d8f6c8cf2679c5389a2f5fd888e29153b0c2
  Author: Gregory A Lundberg <gregory_lundberg at gmx.com>
  Date:   2016-07-16 (Sat, 16 Jul 2016)

  Changed paths:
    M data/campaigns/Liberty/scenarios/02_Civil_Disobedience.cfg
    M data/campaigns/Liberty/scenarios/03_A_Strategy_Of_Hope.cfg
    M data/campaigns/Liberty/scenarios/04_Unlawful_Orders.cfg

  Log Message:
  -----------
  L Fix the Advisor role

Use a consistent type= list and include all advancements when selecting and Advisor.

Harper and Baldras cannot be the Advisor.

No need to search for an Advisor to recall in S03, S02 set one (or not) and it cannot have changed.

Use the new [role] features.


  Commit: 849cacceb16f017186c36d4cd55e2cda8940ee4e
      https://github.com/wesnoth/wesnoth/commit/849cacceb16f017186c36d4cd55e2cda8940ee4e
  Author: Lari Nieminen <lari.nieminen at iki.fi>
  Date:   2016-07-19 (Tue, 19 Jul 2016)

  Changed paths:
    M data/campaigns/Liberty/scenarios/01_The_Raid.cfg
    M data/campaigns/Liberty/scenarios/02_Civil_Disobedience.cfg
    M data/campaigns/Liberty/scenarios/03_A_Strategy_Of_Hope.cfg
    M data/campaigns/Liberty/scenarios/04_Unlawful_Orders.cfg
    M data/campaigns/Liberty/scenarios/05_Hide_and_Seek.cfg
    M data/campaigns/Liberty/scenarios/07_The_Hunters.cfg
    M data/campaigns/Liberty/scenarios/08_Glory.cfg
    M data/campaigns/Liberty/utils/utils.cfg

  Log Message:
  -----------
  Merge pull request #699 from GregoryLundberg/GL_L_final

Liberty fixes


Compare: https://github.com/wesnoth/wesnoth/compare/b02e08406475...849cacceb16f