[Commits] [wesnoth/wesnoth] 9f3639: Tweaked minimal slider magic numbers again so maxi...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 9f3639d5bb8b59f43ed4372e15c2ea4eb698140a
      https://github.com/wesnoth/wesnoth/commit/9f3639d5bb8b59f43ed4372e15c2ea4eb698140a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M data/gui/widget/slider_minimal.cfg

  Log Message:
  -----------
  Tweaked minimal slider magic numbers again so maximum value can be reached (bug #24531)

There seems to possibly be an internal issue with the slider (and more generally, the
scrollbar implementation form which it inherits) where is min/maximum_positioner_length
equal an even number, sliders with an even number of options will reach max value.

Setting it to what, in this case is 1 below the actual width of the slider image (15)
means both even and odd-numbered sliders will reach max value, however the edge is cut off.

Attempting to set the right_offset to 1 and using the above off value for the positioned
width means only sliders with an odd number of options reach max value.

The magic numbers in this commit seem to give the widget enough space to reach the end of
the slider and max values regardless of the number of options, but the internal widget dimension
calculation should perhaps be investigated in the future.