[Commits] [wesnoth/wesnoth] 0bc068: Fix bug #23712: Mage of Light halo not drawing cor...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 0bc068113a9cb8a18f797e4aec29d280653b57d3
      https://github.com/wesnoth/wesnoth/commit/0bc068113a9cb8a18f797e4aec29d280653b57d3
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-06-26 (Sun, 26 Jun 2016)

  Changed paths:
    M changelog
    M players_changelog
    M src/halo.cpp
    M src/units/drawer.cpp

  Log Message:
  -----------
  Fix bug #23712: Mage of Light halo not drawing correctly

The halo is recreated when the mage starts to move, and it's initially
placed in the top-left corner of the screen. On the next frame the game
corrects its position. Correcting the position clears the list of hexes the
halo overlaps, which essentially means "the overlapped hexes aren't known,
update them when the halo is redrawn". However, the game also uses the list
of overlapped hexes to determine when the halo should be invalidated, and
thus redrawn: because the list was empty, the halo was never invalidated,
and it stayed at the top-left corner.

Fixed by placing the halo in the right position to begin with. This commit
includes my previous fixes as well, though, because the code was simply
incorrect before (even if it doesn't break anything any more).


  Commit: 9c179bdc651788573feb06bcbe21733ec97c4809
      https://github.com/wesnoth/wesnoth/commit/9c179bdc651788573feb06bcbe21733ec97c4809
  Author: Andreas <andreas at alternating.net>
  Date:   2016-06-28 (Tue, 28 Jun 2016)

  Changed paths:
    M changelog
    M players_changelog
    M src/halo.cpp
    M src/units/drawer.cpp

  Log Message:
  -----------
  Merge pull request #673 from jyrkive/bug-23712

Fix bug #23712: Mage of Light halo not drawing correctly


Compare: https://github.com/wesnoth/wesnoth/compare/944a1d962a30...9c179bdc6517