[Commits] [wesnoth/wesnoth] c37e9c: Removed display_format_alpha() function

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c37e9c4a7f0f3eff49f568df3de874d7c7a4bdf5
      https://github.com/wesnoth/wesnoth/commit/c37e9c4a7f0f3eff49f568df3de874d7c7a4bdf5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2016-03-13 (Sun, 13 Mar 2016)

  Changed paths:
    M src/display.cpp
    M src/gui/auxiliary/canvas.cpp
    M src/sdl/utils.cpp
    M src/sdl/utils.hpp
    M src/video.cpp
    M src/video.hpp

  Log Message:
  -----------
  Removed display_format_alpha() function

This function's contents were SDL1.2 only, and in SDL2 only return NULL. This
resulted in create_optimized_surface() always returning the passed surface and
get_surface_portion() to potentially return NULL erroneously (if optimize_format
was true, which doesn't seem to be the case anywhere).

However, there haven't been any discernible bugs that resulted from either of these
behaviors, so it should be investigates whether create_optimized_surface() is still
necessary, since it's been operating for a while now simply returning its passed
surface.