[Commits] [wesnoth/wesnoth] 3c5332: scons: Make compiler and Boost version requirement...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3c5332fd05c9790d189b35de3ff3fbd1372e07a4
      https://github.com/wesnoth/wesnoth/commit/3c5332fd05c9790d189b35de3ff3fbd1372e07a4
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M SConstruct

  Log Message:
  -----------
  scons: Make compiler and Boost version requirements match INSTALL


  Commit: 4bc38856ce2db61ef190407f94b41dfb83ad7e9d
      https://github.com/wesnoth/wesnoth/commit/4bc38856ce2db61ef190407f94b41dfb83ad7e9d
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M SConstruct

  Log Message:
  -----------
  scons: Refactor and reword Info()/Warning() message presentation


  Commit: bd9fea0fd3a5862dec9360427abba6b9d0ae05d2
      https://github.com/wesnoth/wesnoth/commit/bd9fea0fd3a5862dec9360427abba6b9d0ae05d2
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M SConstruct

  Log Message:
  -----------
  scons: Drop C-isms


  Commit: c28e3b633c191a7cc923405aa23e09cd8243511c
      https://github.com/wesnoth/wesnoth/commit/c28e3b633c191a7cc923405aa23e09cd8243511c
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2016-11-03 (Thu, 03 Nov 2016)

  Changed paths:
    M scons/cplusplus.py

  Log Message:
  -----------
  scons: Exclude Clang from GCC version checks

SCons stupidly treats Clang as if it were GCC (hint: it's not) and that
causes the config check to fail due to the version symbols being
absent/not what we expect. So just ignore the GCC version when Clang is
detected, in the config test program; we can probably expect whoever is
using Clang to be able to deal with any issues that may arise from
attempting to use a Clang version we don't support.

As for why we don't test the Clang version number, according to
<http://clang.llvm.org/docs/LanguageExtensions.html#builtin-macros>,
"marketing version numbers should not be used to check for language
features, as different vendors use different numbering schemes." And
indeed, it is the case with the versions of Clang shipped with XCode
that they do not accurately reflect the upstream version they correspond
to and have weird version numbers such as 5 (as of this writing upstrema
hasn't even released version 4.0 yet). Such is life.


Compare: https://github.com/wesnoth/wesnoth/compare/b7ee27c8e79d...c28e3b633c19