[Commits] [wesnoth/wesnoth] ec607d: Make tgrid a final class

GitHub noreply at github.com
Sat Nov 5 21:00:18 UTC 2016


  Branch: refs/heads/gui2-min-size-layout
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ec607db39fc37c4f895d3a5986a8685e73d29e88
      https://github.com/wesnoth/wesnoth/commit/ec607db39fc37c4f895d3a5986a8685e73d29e88
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-11-05 (Sat, 05 Nov 2016)

  Changed paths:
    M src/gui/widgets/grid.hpp

  Log Message:
  -----------
  Make tgrid a final class

Tgrid doesn't have any protected members, and is clearly designed not to be
inherited. Enforce it.


  Commit: 852a3f7f6c0c2fef44216c7c9995595a139cf11e
      https://github.com/wesnoth/wesnoth/commit/852a3f7f6c0c2fef44216c7c9995595a139cf11e
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-11-05 (Sat, 05 Nov 2016)

  Changed paths:
    M src/gui/widgets/grid.cpp
    M src/gui/widgets/grid.hpp

  Log Message:
  -----------
  Lay grid out after size reduction

And in particular, do not call calculate_best_size() because it clears
saved row/column sizes.


  Commit: cea1bc926fa775f8bb19140036106d847c163aa8
      https://github.com/wesnoth/wesnoth/commit/cea1bc926fa775f8bb19140036106d847c163aa8
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2016-11-05 (Sat, 05 Nov 2016)

  Changed paths:
    M src/gui/widgets/grid.cpp

  Log Message:
  -----------
  Demote the "failed to place a grid" message from error to info level


Compare: https://github.com/wesnoth/wesnoth/compare/ec607db39fc3^...cea1bc926fa7


More information about the Commits mailing list