[Commits] [wesnoth/wesnoth] d536d6: Implement a destructor subscription system for for...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: d536d6ab7620bde84ca84c064f5200ea19d3460c
      https://github.com/wesnoth/wesnoth/commit/d536d6ab7620bde84ca84c064f5200ea19d3460c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/ai/composite/value_translator.hpp
    M src/ai/default/attack.cpp
    M src/ai/formula/ai.cpp
    M src/ai/formula/ai.hpp
    M src/ai/formula/callable_objects.cpp
    M src/ai/formula/callable_objects.hpp
    M src/ai/formula/candidates.cpp
    M src/ai/formula/function_table.cpp
    M src/ai/formula/stage_side_formulas.cpp
    M src/ai/formula/stage_unit_formulas.cpp
    M src/formula/callable.hpp
    M src/formula/callable_fwd.hpp
    M src/formula/callable_objects.cpp
    M src/formula/callable_objects.hpp
    M src/formula/function.cpp
    M src/formula/variant.cpp
    M src/formula/variant.hpp
    M src/formula/variant_value.cpp
    M src/formula/variant_value.hpp
    M src/gui/core/canvas.cpp
    M src/scripting/lua_formula_bridge.cpp
    M src/tests/test_formula_core.cpp
    M src/units/filter.cpp

  Log Message:
  -----------
  Implement a destructor subscription system for formula_callable

This allows the variant_callable to store a shared_ptr to its callable while ensuring that
callables that were allocated on the stack or as part of a larger structure are not
double-freed.


  Commit: 0b02ba08767c5bbd85d605102812f1eeb3e295a8
      https://github.com/wesnoth/wesnoth/commit/0b02ba08767c5bbd85d605102812f1eeb3e295a8
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/formula/variant.cpp
    M src/formula/variant.hpp

  Log Message:
  -----------
  Make variant constructor from std::shared_ptr a template

For some reason, when the variant constructor only accepts
std::shared_ptr<const variant_callable>, MSVC2013 gets confused about which
constructor it should call when it has, say,
std::shared_ptr<ai::attack_analysis>. Making the constructor a template
fixes it.


  Commit: 165204f159e385607fa7ec10805d464d7fed2cc1
      https://github.com/wesnoth/wesnoth/commit/165204f159e385607fa7ec10805d464d7fed2cc1
  Author: Matthias Krüger <matthias.krueger at famsik.de>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/units/unit.cpp

  Log Message:
  -----------
  unit.cpp: remove unused variable. Found by cppcheck.

[src/units/unit.cpp:2061]: (style) Unused variable: remove_indices


  Commit: 32681af9783c98a5f28141323904299e8f38e951
      https://github.com/wesnoth/wesnoth/commit/32681af9783c98a5f28141323904299e8f38e951
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  fix unused code, found by cppcheck.

[src/game_initialization/multiplayer.cpp:685]: (style) Variable 'label' is assigned a value that is never used.


  Commit: abb47d13ab163c838001314bc4153a3313ea4fd1
      https://github.com/wesnoth/wesnoth/commit/abb47d13ab163c838001314bc4153a3313ea4fd1
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/ai/testing.cpp

  Log Message:
  -----------
  Minor cleanup of ai_testing output

(There were some missing spaces in the output)


  Commit: ac6a62046e95c9a9fc75230077f7c95c2fca600b
      https://github.com/wesnoth/wesnoth/commit/ac6a62046e95c9a9fc75230077f7c95c2fca600b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/play_controller.cpp
    M src/play_controller.hpp
    M src/scripting/game_lua_kernel.cpp
    M src/scripting/game_lua_kernel.hpp

  Log Message:
  -----------
  Add wesnoth.log_replay which adds stuff to the saved game in [upload_log]


  Commit: 795592fe12f51cba769b8d114f7a37e0b76f002b
      https://github.com/wesnoth/wesnoth/commit/795592fe12f51cba769b8d114f7a37e0b76f002b
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M src/ai/composite/value_translator.hpp
    M src/ai/default/attack.cpp
    M src/ai/formula/ai.cpp
    M src/ai/formula/ai.hpp
    M src/ai/formula/callable_objects.cpp
    M src/ai/formula/callable_objects.hpp
    M src/ai/formula/candidates.cpp
    M src/ai/formula/function_table.cpp
    M src/ai/formula/stage_side_formulas.cpp
    M src/ai/formula/stage_unit_formulas.cpp
    M src/formula/callable.hpp
    M src/formula/callable_fwd.hpp
    M src/formula/callable_objects.cpp
    M src/formula/callable_objects.hpp
    M src/formula/function.cpp
    M src/formula/variant.cpp
    M src/formula/variant.hpp
    M src/formula/variant_value.cpp
    M src/formula/variant_value.hpp
    M src/gui/core/canvas.cpp
    M src/scripting/lua_formula_bridge.cpp
    M src/tests/test_formula_core.cpp
    M src/units/filter.cpp

  Log Message:
  -----------
  Merge branch 'wfl_memleak_fix'


  Commit: dd7296a3595741eee998033e9154dd093abbb710
      https://github.com/wesnoth/wesnoth/commit/dd7296a3595741eee998033e9154dd093abbb710
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-08 (Sat, 08 Apr 2017)

  Changed paths:
    M changelog

  Log Message:
  -----------
  Update changelog


Compare: https://github.com/wesnoth/wesnoth/compare/ec6191a68e0b...dd7296a35957