[Commits] [wesnoth/wesnoth] 7d8380: GUI2: marked inherited dialog functions (pre_show, ...

GitHub noreply at github.com
Wed Apr 12 06:45:27 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 7d8380cd8781693871e5c45649e9fcb94dddccb7
      https://github.com/wesnoth/wesnoth/commit/7d8380cd8781693871e5c45649e9fcb94dddccb7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/gui/dialogs/addon/connect.hpp
    M src/gui/dialogs/addon/install_dependencies.hpp
    M src/gui/dialogs/addon/manager.hpp
    M src/gui/dialogs/addon/uninstall_list.hpp
    M src/gui/dialogs/advanced_graphics_options.hpp
    M src/gui/dialogs/attack_predictions.hpp
    M src/gui/dialogs/campaign_difficulty.hpp
    M src/gui/dialogs/campaign_selection.hpp
    M src/gui/dialogs/campaign_settings.hpp
    M src/gui/dialogs/chat_log.cpp
    M src/gui/dialogs/chat_log.hpp
    M src/gui/dialogs/core_selection.hpp
    M src/gui/dialogs/debug_clock.hpp
    M src/gui/dialogs/depcheck_confirm_change.hpp
    M src/gui/dialogs/depcheck_select_new.hpp
    M src/gui/dialogs/drop_down_menu.hpp
    M src/gui/dialogs/edit_label.hpp
    M src/gui/dialogs/edit_text.hpp
    M src/gui/dialogs/editor/custom_tod.hpp
    M src/gui/dialogs/editor/edit_label.hpp
    M src/gui/dialogs/editor/edit_scenario.hpp
    M src/gui/dialogs/editor/edit_side.hpp
    M src/gui/dialogs/editor/generate_map.hpp
    M src/gui/dialogs/editor/generator_settings.hpp
    M src/gui/dialogs/editor/new_map.hpp
    M src/gui/dialogs/editor/resize_map.hpp
    M src/gui/dialogs/editor/set_starting_position.hpp
    M src/gui/dialogs/end_credits.hpp
    M src/gui/dialogs/file_dialog.hpp
    M src/gui/dialogs/folder_create.hpp
    M src/gui/dialogs/formula_debugger.hpp
    M src/gui/dialogs/game_cache_options.hpp
    M src/gui/dialogs/game_delete.hpp
    M src/gui/dialogs/game_load.hpp
    M src/gui/dialogs/game_save.hpp
    M src/gui/dialogs/game_stats.hpp
    M src/gui/dialogs/game_version.hpp
    M src/gui/dialogs/gamestate_inspector.hpp
    M src/gui/dialogs/help_browser.hpp
    M src/gui/dialogs/hotkey_bind.hpp
    M src/gui/dialogs/label_settings.hpp
    M src/gui/dialogs/language_selection.hpp
    M src/gui/dialogs/loading_screen.hpp
    M src/gui/dialogs/lobby/lobby.hpp
    M src/gui/dialogs/lobby/player_info.hpp
    M src/gui/dialogs/log_settings.hpp
    M src/gui/dialogs/lua_interpreter.hpp
    M src/gui/dialogs/message.hpp
    M src/gui/dialogs/multiplayer/faction_select.hpp
    M src/gui/dialogs/multiplayer/mp_alerts_options.hpp
    M src/gui/dialogs/multiplayer/mp_change_control.cpp
    M src/gui/dialogs/multiplayer/mp_change_control.hpp
    M src/gui/dialogs/multiplayer/mp_cmd_wrapper.hpp
    M src/gui/dialogs/multiplayer/mp_connect.cpp
    M src/gui/dialogs/multiplayer/mp_connect.hpp
    M src/gui/dialogs/multiplayer/mp_create_game.hpp
    M src/gui/dialogs/multiplayer/mp_host_game_prompt.hpp
    M src/gui/dialogs/multiplayer/mp_join_game.hpp
    M src/gui/dialogs/multiplayer/mp_join_game_password_prompt.hpp
    M src/gui/dialogs/multiplayer/mp_login.hpp
    M src/gui/dialogs/multiplayer/mp_method_selection.hpp
    M src/gui/dialogs/multiplayer/mp_staging.hpp
    M src/gui/dialogs/multiplayer/synced_choice_wait.hpp
    M src/gui/dialogs/network_transmission.hpp
    M src/gui/dialogs/outro.hpp
    M src/gui/dialogs/preferences_dialog.hpp
    M src/gui/dialogs/screenshot_notification.hpp
    M src/gui/dialogs/select_orb_colors.hpp
    M src/gui/dialogs/simple_item_selector.hpp
    M src/gui/dialogs/sp_options_configure.hpp
    M src/gui/dialogs/statistics_dialog.hpp
    M src/gui/dialogs/story_viewer.hpp
    M src/gui/dialogs/terrain_layers.hpp
    M src/gui/dialogs/theme_list.hpp
    M src/gui/dialogs/title_screen.hpp
    M src/gui/dialogs/tooltip.cpp
    M src/gui/dialogs/transient_message.hpp
    M src/gui/dialogs/unit_advance.hpp
    M src/gui/dialogs/unit_attack.hpp
    M src/gui/dialogs/unit_create.hpp
    M src/gui/dialogs/unit_list.hpp
    M src/gui/dialogs/unit_recall.hpp
    M src/gui/dialogs/unit_recruit.hpp
    M src/gui/dialogs/wml_error.hpp
    M src/gui/dialogs/wml_message.hpp

  Log Message:
  -----------
  GUI2: marked inherited dialog functions (pre_show, etc) as virtual override

The virtual is for style consistency, the override because it should be done.





More information about the Commits mailing list