[Commits] [wesnoth/wesnoth] c44de3: remove unused bool return value

GitHub noreply at github.com
Wed Apr 12 13:16:19 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: c44de30a0921b383dc42e01ae5c8b09d61e0a37e
      https://github.com/wesnoth/wesnoth/commit/c44de30a0921b383dc42e01ae5c8b09d61e0a37e
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/actions/move.cpp

  Log Message:
  -----------
  remove unused bool return value


  Commit: 4908124f6fe04aeda1c99f871a0748e9bb987076
      https://github.com/wesnoth/wesnoth/commit/4908124f6fe04aeda1c99f871a0748e9bb987076
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/actions/move.cpp

  Log Message:
  -----------
  some clenaups

mainly adding backets to one-line if bodies


  Commit: 75c21815f686f77b09103bb8757fea1318d4ac5e
      https://github.com/wesnoth/wesnoth/commit/75c21815f686f77b09103bb8757fea1318d4ac5e
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M data/gui/schema.cfg
    M src/gui/widgets/multi_page.cpp
    M src/gui/widgets/multi_page.hpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  allow multi_page to contain differnt types of pages

although stacked_widget supports similar functionality this is currently
not easily doable from the lua gui2 api. In particular
1) stacked_widget cannot add pages dynamically
2) multi_page can only contain one type of widget.
3) a stacked_widget inside a multi_page is ineffective since it
generates many unused widgets
4) a multi_page inside a stacked_widget is just unhandy to use


Compare: https://github.com/wesnoth/wesnoth/compare/de8419deb725...75c21815f686


More information about the Commits mailing list