[Commits] [wesnoth/wesnoth] 48142d: Fix advanced preferences not shrinking when the pl...

GitHub noreply at github.com
Wed Apr 12 17:34:31 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 48142dd8212a33891b26a0dfe06dba8393e9e049
      https://github.com/wesnoth/wesnoth/commit/48142dd8212a33891b26a0dfe06dba8393e9e049
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-04-12 (Wed, 12 Apr 2017)

  Changed paths:
    M src/gui/widgets/widget.cpp
    M src/gui/widgets/widget.hpp

  Log Message:
  -----------
  Fix advanced preferences not shrinking when the player deselects them

It turns out that I had misunderstood the purpose of widget::layout_size_.
It's not a cache, it's an override. It's only set for widgets which have
been shrunk or whose sizes have otherwise been changed from the preferred
size.

As a result, commit c4be6a7ec881d74a0d46f3b068053b86bc1c7e17 ended up skipping relayout way too often.





More information about the Commits mailing list