[Commits] [wesnoth/wesnoth] f6b491: Some cleanup to the unit frame code

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f6b4917027616cf193012c5a878198dc61582007
      https://github.com/wesnoth/wesnoth/commit/f6b4917027616cf193012c5a878198dc61582007
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-13 (Thu, 13 Apr 2017)

  Changed paths:
    M src/units/frame.cpp

  Log Message:
  -----------
  Some cleanup to the unit frame code

Explanations:
- Removed all the redundant constructor initializers
- Don't initialize the color members.
  (Otherwise what's the point of it being an optional?)
- Some collapsing of stuff like ? true : false and similar cases
- Use operator* and operator-> instead of get() for optionals
-


  Commit: c97adacfa79e3562d759e9e9f43741ab00fd42b1
      https://github.com/wesnoth/wesnoth/commit/c97adacfa79e3562d759e9e9f43741ab00fd42b1
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-04-13 (Thu, 13 Apr 2017)

  Changed paths:
    M src/units/frame.cpp

  Log Message:
  -----------
  Re-fix poison not being shown


Compare: https://github.com/wesnoth/wesnoth/compare/f3a574da46f8...c97adacfa79e