[Commits] [wesnoth/wesnoth] 30340a: Display: removed dummy drawing layer

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 30340aaedbaaa14de0f3bac2ac88345f575e0485
      https://github.com/wesnoth/wesnoth/commit/30340aaedbaaa14de0f3bac2ac88345f575e0485
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M src/display.cpp
    M src/display.hpp

  Log Message:
  -----------
  Display: removed dummy drawing layer

Not exactly sure what it meant by "sizing the vector" - the enum isn't a vector, or used in a vector. It doesn't
seem to have been relevant to max_layer_group either, since that was calculated with a -2 offset to ignore it.

Likely it had to do with the loop in drawing_buffer_key ctor, which was designed to find the group (which is
drawing_layer an enum member) "under" (ie, that contained) the specified layer. Having a dummy buffer meant the
precondition of layer < max layer (ie, the buffer) layer was always true, meaning the index was always decremented
at least once.


  Commit: 3252348dd698e213ccf5f04b8173c097774c58c7
      https://github.com/wesnoth/wesnoth/commit/3252348dd698e213ccf5f04b8173c097774c58c7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M src/display.cpp

  Log Message:
  -----------
  Attempt to fix build on XCode


Compare: https://github.com/wesnoth/wesnoth/compare/8b926cc3eba4...3252348dd698