[Commits] [wesnoth/wesnoth] ad8715: Move instead of copy when trimming menu lists

GitHub noreply at github.com
Sat Apr 22 16:01:50 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: ad871581ef1fa989a613e2e5f8d39df71a3ac10d
      https://github.com/wesnoth/wesnoth/commit/ad871581ef1fa989a613e2e5f8d39df71a3ac10d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-23 (Sun, 23 Apr 2017)

  Changed paths:
    M src/hotkey/hotkey_handler.cpp

  Log Message:
  -----------
  Move instead of copy when trimming menu lists


  Commit: 7790442b0c6116401b313e6cd35b658edc59bb97
      https://github.com/wesnoth/wesnoth/commit/7790442b0c6116401b313e6cd35b658edc59bb97
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-23 (Sun, 23 Apr 2017)

  Changed paths:
    M src/hotkey/hotkey_handler.cpp

  Log Message:
  -----------
  Cleaned up menu-related code in play_controller::hotkey_handler

For show_menu, there's no need for an explicit check to "save" the autosaves entry anymore, since we add
entries to the item list instead of removing them.

For expand_autosaves, I shouldn't have made the saves list a config just to transform it back to a string.
I only did that since trim_items took a vector of configs. I've now made it templated.


Compare: https://github.com/wesnoth/wesnoth/compare/5aa7ba098cb8...7790442b0c61


More information about the Commits mailing list