[Commits] [wesnoth/wesnoth] 47d77c: Story Viewer: delegate storyscreen controller crea...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 47d77c79d4fc2427ee4cd161d357142fe785b08e
      https://github.com/wesnoth/wesnoth/commit/47d77c79d4fc2427ee4cd161d357142fe785b08e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-30 (Sun, 30 Apr 2017)

  Changed paths:
    M projectfiles/CodeBlocks/wesnoth.cbp
    M source_lists/wesnoth
    M src/gui/dialogs/story_viewer.cpp
    M src/gui/dialogs/story_viewer.hpp
    M src/playsingle_controller.cpp
    R src/storyscreen/interface.cpp
    R src/storyscreen/interface.hpp

  Log Message:
  -----------
  Story Viewer: delegate storyscreen controller creation to dialog

I left the controller passed in an argument for compatibility with the GUI1 dialog, but since that's removed
it makes sense that the dialog handle the creation of the controller, especially since due to an oversight
it made a copy instead of holding a reference.

This also allows storyscreen/interface.*pp to be removed. The START_POSITION was part of the GUI1 implementation
and isn't needed anymore.