[Commits] [wesnoth/wesnoth] a42d41: Editor: refactored global labels handling to avoid...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a42d418bee574a76154c49881e52d4247b906d56
      https://github.com/wesnoth/wesnoth/commit/a42d418bee574a76154c49881e52d4247b906d56
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-30 (Sun, 30 Apr 2017)

  Changed paths:
    M src/editor/map/context_manager.cpp

  Log Message:
  -----------
  Editor: refactored global labels handling to avoid static pointer to context internals

This should *finally* fix the crash when closing a map (bug #25680). I forgot that the pointer
wouldn't automatically be reset to nullptr when the context to whose labels the pointer was to
was destroyed. Would have been simplest to do that manually, but this makes the code a lot less
confusing and avoid future scenarios where that pointer might be pointing to freed memory.


  Commit: 9c222772c042b826eecf3a0a139d5b5532e68ddc
      https://github.com/wesnoth/wesnoth/commit/9c222772c042b826eecf3a0a139d5b5532e68ddc
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-04-30 (Sun, 30 Apr 2017)

  Changed paths:
    M src/editor/action/mouse/mouse_action_map_label.cpp

  Log Message:
  -----------
  Editor: fixed label color settings not being respected


Compare: https://github.com/wesnoth/wesnoth/compare/309f708c7bb8...9c222772c042