[Commits] [wesnoth/wesnoth] 4a9f64: Warning: ignored return value of freopen

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4a9f64bd53f548da27be2625b1f073ac9740493f
      https://github.com/wesnoth/wesnoth/commit/4a9f64bd53f548da27be2625b1f073ac9740493f
  Author: lundberg <gregory_lundberg at gmx.com>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M src/log_windows.cpp

  Log Message:
  -----------
  Warning: ignored return value of freopen


  Commit: 51fdcd5d9468bfc52fbc4432424392c15abf2253
      https://github.com/wesnoth/wesnoth/commit/51fdcd5d9468bfc52fbc4432424392c15abf2253
  Author: lundberg <gregory_lundberg at gmx.com>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M src/serialization/string_utils.cpp

  Log Message:
  -----------
  Warning signed vs unsigned char conversion to int

The entire set of functions should be rewritten correctly but this is a 'least change' fix for the specific message.


  Commit: 7b63beea8992815fdf1eb296da9a03fde881f739
      https://github.com/wesnoth/wesnoth/commit/7b63beea8992815fdf1eb296da9a03fde881f739
  Author: lundberg <gregory_lundberg at gmx.com>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M src/attack_prediction.cpp

  Log Message:
  -----------
  Fix warning doing arithmetic on a boolean


  Commit: c861729ac987d4a07cb5fa5ffbb4dce6a413b052
      https://github.com/wesnoth/wesnoth/commit/c861729ac987d4a07cb5fa5ffbb4dce6a413b052
  Author: lundberg <gregory_lundberg at gmx.com>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  Fix warning 'u' might be null

This was a false positive raised due to poor programming style.


  Commit: a166348f846509196888287c3f3b6ebb3d4944aa
      https://github.com/wesnoth/wesnoth/commit/a166348f846509196888287c3f3b6ebb3d4944aa
  Author: lundberg <gregory_lundberg at gmx.com>
  Date:   2017-08-05 (Sat, 05 Aug 2017)

  Changed paths:
    M src/reports.cpp

  Log Message:
  -----------
  TODO implemented

per request. untested.


Compare: https://github.com/wesnoth/wesnoth/compare/3acd4b870799...a166348f8465