[Commits] [wesnoth/wesnoth] a487ba: Map/Labels: formatting cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a487ba4b811c8631d2b52c0466ce8f8f52cd071a
      https://github.com/wesnoth/wesnoth/commit/a487ba4b811c8631d2b52c0466ce8f8f52cd071a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/map/label.cpp
    M src/map/label.hpp

  Log Message:
  -----------
  Map/Labels: formatting cleanup


  Commit: 5e0dfb0abbfaade830c094de78ea04dd73c28bc7
      https://github.com/wesnoth/wesnoth/commit/5e0dfb0abbfaade830c094de78ea04dd73c28bc7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/editor/action/action_label.hpp
    M src/editor/action/mouse/mouse_action_map_label.hpp
    M src/gui/dialogs/editor/edit_label.hpp

  Log Message:
  -----------
  Cleaned up some unnecessary map/label.hpp includes in headers


  Commit: 7b85d7b1138fd6fd0e8200e9e96351a6cec501d0
      https://github.com/wesnoth/wesnoth/commit/7b85d7b1138fd6fd0e8200e9e96351a6cec501d0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/map/label.cpp
    M src/map/label.hpp

  Log Message:
  -----------
  Map/Label: cleanup and refactoring

Mostly making it so the map_labels objects store their labels directly instead of as pointers.
Pointers were probably used to avoid copy operations since the copy ctor was deliberately deleted.
However, that's moot now with C++11 and move semantics.


  Commit: 9c15e54bafb4ac4e51e6005b3ed6de99f705c28a
      https://github.com/wesnoth/wesnoth/commit/9c15e54bafb4ac4e51e6005b3ed6de99f705c28a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/gui/core/canvas.cpp

  Log Message:
  -----------
  Minor cleanup to 6110fb5


  Commit: 193baf2c2260509ba1466680c06fe717f6015dac
      https://github.com/wesnoth/wesnoth/commit/193baf2c2260509ba1466680c06fe717f6015dac
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M data/themes/editor.cfg

  Log Message:
  -----------
  Themes/Editor: removed golden border from top and right of map

[ci skip]

Not really necessary, just took up space. Partly addressed #1844. As for the new [main_map] rect numbers, I
just played around with them until they filled the available space.


  Commit: 6d15eee917f80ab7510fad400b41a2eed9e6321b
      https://github.com/wesnoth/wesnoth/commit/6d15eee917f80ab7510fad400b41a2eed9e6321b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: added select_row_at function

See header docs for explanation.


  Commit: f4bccd6dfeb0ae07864bb092cf135a9bf05fb66a
      https://github.com/wesnoth/wesnoth/commit/f4bccd6dfeb0ae07864bb092cf135a9bf05fb66a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/gui/dialogs/modal_dialog.cpp
    M src/gui/dialogs/modal_dialog.hpp
    M src/gui/dialogs/modeless_dialog.hpp

  Log Message:
  -----------
  GUI2/Dialogs: added window ptr getters to modal_dialog and modeless_dialog

To facilitate this the window unique_ptr was promoted to class member in modal_dialog. This will
allow fetching the window without binding it to every single callback in existence.


  Commit: 871a69935e83c6c3695ccb4babb0c7c34d6138eb
      https://github.com/wesnoth/wesnoth/commit/871a69935e83c6c3695ccb4babb0c7c34d6138eb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2/Window: removed unnecessary get_window functions

The comments are misleading. If they ever were true in the past, they aren't anymore, and these are
rather useless anyway. You'd need a window object to call them, and if you have the object already,
there's no need for a getter that returns itself.


  Commit: bdb9b4a5131cb0b1fc1e04059b8afd4a3b217ae7
      https://github.com/wesnoth/wesnoth/commit/bdb9b4a5131cb0b1fc1e04059b8afd4a3b217ae7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/gui/widgets/chatbox.hpp
    M src/gui/widgets/group.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/scrollbar.hpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/unit_preview_pane.hpp
    M src/gui/widgets/widget.hpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2: fixed a bunch of typos

[ci skip]

Also has one or two minor comment formatting fixups.


  Commit: 5e650d3bc1308654e5b08d39b81f7ed179bff58e
      https://github.com/wesnoth/wesnoth/commit/5e650d3bc1308654e5b08d39b81f7ed179bff58e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/widgets/addon_list.cpp

  Log Message:
  -----------
  GUI2/Addon Manager: fixed delete buttons not functioning correctly for published addons

Fixed the following:

* The large delete button was always being grayed out for publishable addons.
* The small delete button was only being displayed for publishable addons where the local version equaled
  the remote version.

New behavior:
* Both delete buttons are grayed out for non-published addons and displayed always otherwise.


  Commit: 470d8956b85088ce02a26c6bbc5856a35ea3eea3
      https://github.com/wesnoth/wesnoth/commit/470d8956b85088ce02a26c6bbc5856a35ea3eea3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M data/gui/widget/addon_list.cfg
    M src/gui/widgets/addon_list.cpp

  Log Message:
  -----------
  GUI2/Addon List: restored extra version display for upgradable or outdated addons

The old GUI1 addon manager displayed both local and published versions of the addon directly in the list
if the addon was upgradable or outdated on the server. It seems to have gotten lost in the transition, so
this restores it.


  Commit: 842eb186d3044803b2e8a1ba9a55ba7a25bf3b4f
      https://github.com/wesnoth/wesnoth/commit/842eb186d3044803b2e8a1ba9a55ba7a25bf3b4f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M src/addon/state.hpp
    M src/gui/dialogs/addon/manager.cpp

  Log Message:
  -----------
  GUI2/Addon Manager: added status filter for publishable addons


Compare: https://github.com/wesnoth/wesnoth/compare/98c83915ef19...842eb186d304