[Commits] [wesnoth/wesnoth] 8bf57d: wmlunits: Wire in Wesmere header and trailer

Sat Aug 12 06:27:25 UTC 2017

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 8bf57d6fe06f32dc3bbb42ad0a9b3ac164e0df1f
      https://github.com/wesnoth/wesnoth/commit/8bf57d6fe06f32dc3bbb42ad0a9b3ac164e0df1f
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-06 (Sun, 06 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/wmlunits

  Log Message:
  -----------
  wmlunits: Wire in Wesmere header and trailer

  Commit: 416e3b5479934e97527aa9211b37080e8ce184c6
      https://github.com/wesnoth/wesnoth/commit/416e3b5479934e97527aa9211b37080e8ce184c6
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-06 (Sun, 06 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: First markup clean-up pass

  Commit: d0c43b89c46e2603c79427502aad8327d0d58dd6
      https://github.com/wesnoth/wesnoth/commit/d0c43b89c46e2603c79427502aad8327d0d58dd6
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-06 (Sun, 06 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py

  Log Message:
  -----------
  wmlunits: SEO-friendly page titles, and extra root element classes

  Commit: e9287e5b6be6b965560808e2fd59efcd794b4c96
      https://github.com/wesnoth/wesnoth/commit/e9287e5b6be6b965560808e2fd59efcd794b4c96
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-06 (Sun, 06 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py

  Log Message:
  -----------
  wmlunits: Rechristening Overview as the Build Report, table structure cleanup

  Commit: d4fb54345117f3c178f07182665f55bf50f1a514
      https://github.com/wesnoth/wesnoth/commit/d4fb54345117f3c178f07182665f55bf50f1a514
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-06 (Sun, 06 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Make the sidebar and popup menus markup more proper (<ul>/<li>)

The language menu gets to stay as a <div> containing a table for now
since doing columns with lists is still not that well supported across
browsers (as well as the CSS columns spec as a whole -- too many legacy
browsers floating around).

  Commit: 6b5ba55fbc0e3d1b2ad30f0746b7dd1e4f772e51
      https://github.com/wesnoth/wesnoth/commit/6b5ba55fbc0e3d1b2ad30f0746b7dd1e4f772e51
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-07 (Mon, 07 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py

  Log Message:
  -----------
  wmlunits: Restore build timestamp at the end

  Commit: ee66b96025558e24a6e22fef5e4e35fa5addc921
      https://github.com/wesnoth/wesnoth/commit/ee66b96025558e24a6e22fef5e4e35fa5addc921
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-07 (Mon, 07 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Use CSS to ensure sprites still fit in the tree when overlaid

  Commit: 7e2538a828a3a5ad6a3526ff1f133756f244f9eb
      https://github.com/wesnoth/wesnoth/commit/7e2538a828a3a5ad6a3526ff1f133756f244f9eb
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-07 (Mon, 07 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Allow styling unit attributes in the unit tree view

  Commit: 53bc16b91fdddf9274fcf45a84d13926b32fac27
      https://github.com/wesnoth/wesnoth/commit/53bc16b91fdddf9274fcf45a84d13926b32fac27
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-07 (Mon, 07 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Various formatting/structure improvements

* There is now a link back to units.wesnoth.org on the navbar preceding
  Home.
* The mulitplication sign is used for attack stats to match 1.13.x.
* Made the Terrain table in the unit detail pages a bit more proper
  markup-wise.
* Advances from/to on the unit detail page displays a dash when empty
  and also has a comma-separated list of unit links in it. The same goes
  for the abilities list.

  Commit: 75a5af127a442a6541008add2b49fa4355d9c127
      https://github.com/wesnoth/wesnoth/commit/75a5af127a442a6541008add2b49fa4355d9c127
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Fix issues with off-by-one column counts in unit view tables

  Commit: d14c0dccd444d16f4e63babbcb15e554ddc23557
      https://github.com/wesnoth/wesnoth/commit/d14c0dccd444d16f4e63babbcb15e554ddc23557
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Hide Terrain column label from the unit view page

  Commit: c63102c4a91bde94453bc826af3181c2b27e2bd2
      https://github.com/wesnoth/wesnoth/commit/c63102c4a91bde94453bc826af3181c2b27e2bd2
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Make sure all language menu table rows are equal in length

  Commit: 692a59f297f2a3a42a124be3a05ae87ab0bc37b5
      https://github.com/wesnoth/wesnoth/commit/692a59f297f2a3a42a124be3a05ae87ab0bc37b5
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Add coloring classes to unit attributes in the unit details view

This applies to resistances, movement costs, and defense.

  Commit: 78e44d72709796831a5b2357cdeac5b2a0b9d66a
      https://github.com/wesnoth/wesnoth/commit/78e44d72709796831a5b2357cdeac5b2a0b9d66a
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Revised color scales per vultraz's feedback

  Commit: 2134d048a71a7d6ca46b640752ae441a6eb6d23e
      https://github.com/wesnoth/wesnoth/commit/2134d048a71a7d6ca46b640752ae441a6eb6d23e
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Use figure dashes instead of hyphens for empty placeholders

  Commit: edf270abef420a9dee6bcd65127f87c46d8e7501
      https://github.com/wesnoth/wesnoth/commit/edf270abef420a9dee6bcd65127f87c46d8e7501
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Tidy up unit tree attributes a bit using mini tables

  Commit: 7625b5c5b2a788b47664ad4fb133c041225666b1
      https://github.com/wesnoth/wesnoth/commit/7625b5c5b2a788b47664ad4fb133c041225666b1
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-08 (Tue, 08 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Use www.wesnoth.org URLs for resources

  Commit: 4d5a4fc4c65261ce63a45d0b4a2684dc59675708
      https://github.com/wesnoth/wesnoth/commit/4d5a4fc4c65261ce63a45d0b4a2684dc59675708
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py

  Log Message:
  -----------
  wmlunits: Escape generated URLs and WML-defined output

Some refactoring and a lot of code changes are involved in this.
Basically, wmlunits has always fully trusted its WML input. This has
several implications:

 * URLs such as the ones for unit detail views tend to contain
   unescaped characters which are forbidden in URLs, such as spaces.
   While browsers generally tolerate this well, the result is still
   invalid HTML. The same applies to URLs used for inline CSS (e.g.
   background-image).

 * Most information read from WML such as unit names, descriptions,
   campaign names, era names, and so on, was blindly trusted and could
   allow an attacker to inject malicious HTML into units.wesnoth.org by
   uploading an add-on that would pass the units.wesnoth.org build
   process.

The resulting code might not be extent of regressions, but hopefully
we'll identify them quickly. This commit contains some additional noise
in the form of style fixes around offending lines as well. Backporting
to 1.12 is, as far as I understand, unnecessary since units.wesnoth.org
uses the master branch version of wmlunits, but it might be worth
evaluating whether to issue a warning for the 1 person in the world who
might be running the 1.12 version of the units.wesnoth.org toolchain on
their own facilities (okay, let's face it, nobody would ever do that).

  Commit: a0029c06d19c794ac0c62aae3f3f7892663c4911
      https://github.com/wesnoth/wesnoth/commit/a0029c06d19c794ac0c62aae3f3f7892663c4911
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-09 (Wed, 09 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py

  Log Message:
  -----------
  wmlunits: Couple of cosmetic fixes

  Commit: 400d419b548b10a18eb9157daa25285a6b4b146b
      https://github.com/wesnoth/wesnoth/commit/400d419b548b10a18eb9157daa25285a6b4b146b
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/menu.js

  Log Message:
  -----------
  wmlunits: New pop-up menu implementation

The new code has a smaller markup fingerprint (no more inline event
Javascript attributes) and it also ports the outer-click-dismiss
functionality over from the wiki. It raises the Javascript engine
requirements to IE 9 and later, though, which is inline with the home
page code.

  Commit: b660be8fd7cf2abe1dedcf05d9a9c35e94f0cff0
      https://github.com/wesnoth/wesnoth/commit/b660be8fd7cf2abe1dedcf05d9a9c35e94f0cff0
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: Refactor + pylint pass 1

  Commit: b7b4efcf76b06e79ef5d934efe07bb8663a5c516
      https://github.com/wesnoth/wesnoth/commit/b7b4efcf76b06e79ef5d934efe07bb8663a5c516
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py

  Log Message:
  -----------
  wmlunits: pylint pass 2

  Commit: 743d8c22788fb1cd585066415a76ba3653a3a18e
      https://github.com/wesnoth/wesnoth/commit/743d8c22788fb1cd585066415a76ba3653a3a18e
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py

  Log Message:
  -----------
  wmlunits: More cleanup

  Commit: fcba9f498da6bf555e104557a95b34d698402b56
      https://github.com/wesnoth/wesnoth/commit/fcba9f498da6bf555e104557a95b34d698402b56
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-11 (Fri, 11 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py

  Log Message:
  -----------
  wmlunits: Refactoring and quote clean-up

  Commit: 9db2ed630c4e56b94ce2d8421816392a45ee4ba2
      https://github.com/wesnoth/wesnoth/commit/9db2ed630c4e56b94ce2d8421816392a45ee4ba2
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-12 (Sat, 12 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/helpers.py
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/overview.py
    M data/tools/wmlunits

  Log Message:
  -----------
  wmlunits: More code clean-up

  Commit: 5bcaaaf9f7af5cd84f9ff43618df08ca73650b83
      https://github.com/wesnoth/wesnoth/commit/5bcaaaf9f7af5cd84f9ff43618df08ca73650b83
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-12 (Sat, 12 Aug 2017)

  Changed paths:
    R data/tools/unit_tree/style.css
    M data/tools/wmlunits

  Log Message:
  -----------
  wmlunits: style.css is not used anymore

  Commit: 086de4a8973c7677de2e75a0f67383ae52a9847f
      https://github.com/wesnoth/wesnoth/commit/086de4a8973c7677de2e75a0f67383ae52a9847f
  Author: Ignacio R. Morelle <shadowm at wesnoth.org>
  Date:   2017-08-12 (Sat, 12 Aug 2017)

  Changed paths:
    M data/tools/unit_tree/helpers.py
    M data/tools/unit_tree/html_output.py
    M data/tools/unit_tree/menu.js
    M data/tools/unit_tree/overview.py
    R data/tools/unit_tree/style.css
    M data/tools/wmlunits

  Log Message:
  -----------
  Merge branch 'staging/wesmere-wmlunits'

Compare: https://github.com/wesnoth/wesnoth/compare/5c701f207b17...086de4a8973c