[Commits] [wesnoth/wesnoth] 2c07b3: Address feedback from Clang static analyzer (#1877...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 2c07b397f9d71bb2fad73ac2db9595eab7623cd4
      https://github.com/wesnoth/wesnoth/commit/2c07b397f9d71bb2fad73ac2db9595eab7623cd4
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-08-20 (Sun, 20 Aug 2017)

  Changed paths:
    M src/actions/attack.cpp
    M src/generators/default_map_generator_job.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/gui/widgets/settings.cpp
    M src/sdl/utils.cpp
    M src/serialization/preprocessor.cpp
    M src/terrain/builder.cpp
    M src/terrain/translation.cpp
    M src/widgets/scrollbar.cpp

  Log Message:
  -----------
  Address feedback from Clang static analyzer (#1877)

I left alone external libraries, as well as false positives and a bunch of
miscellaneous cases where the existing code is fine (e.g. using floating
point loop indices in scale_surface_sharp() is intentional).

Closes #1877.