[Commits] [wesnoth/wesnoth] 001a2a: GUI2/Text Box Base: made ctrl+a select all text

[GitHub]

  Branch: refs/heads/some_gui2_refactoring
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 001a2a523bdbd099bd52e82b3cdfa63419d38712
      https://github.com/wesnoth/wesnoth/commit/001a2a523bdbd099bd52e82b3cdfa63419d38712
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/text_box_base.cpp

  Log Message:
  -----------
  GUI2/Text Box Base: made ctrl+a select all text

Previously it was an alias for HOME, which is unintuitive and rather useless.


  Commit: 32c18f613446916f98be417877622b973176622e
      https://github.com/wesnoth/wesnoth/commit/32c18f613446916f98be417877622b973176622e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/loading_screen.cpp

  Log Message:
  -----------
  GUI2/Loading Screen: formatting cleanup


  Commit: 19af90ec71843cfbd19fe46f6114b1a7388e02ba
      https://github.com/wesnoth/wesnoth/commit/19af90ec71843cfbd19fe46f6114b1a7388e02ba
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/editor/custom_tod.cpp
    M src/gui/dialogs/editor/edit_label.cpp
    M src/gui/dialogs/editor/edit_scenario.cpp
    M src/gui/dialogs/editor/edit_side.cpp
    M src/gui/dialogs/multiplayer/mp_login.cpp

  Log Message:
  -----------
  GUI2: require existence of all widgets added to tab order

Not sure if window::add_to_tab_order should take a reference in this case.


  Commit: cf8060c8a09e8edd06d81985ab7b57c429ab8452
      https://github.com/wesnoth/wesnoth/commit/cf8060c8a09e8edd06d81985ab7b57c429ab8452
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/chat_log.cpp
    M src/gui/dialogs/editor/edit_side.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/game_cache_options.cpp
    M src/gui/dialogs/loading_screen.cpp
    M src/gui/dialogs/lobby/player_info.cpp
    M src/gui/dialogs/lua_interpreter.cpp
    M src/gui/dialogs/multiplayer/mp_alerts_options.cpp
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  GUI2: use find_widget overload returning a pointer when applicable

Instead of taking address-of the reference version.


  Commit: c980ffc74febfd9f5e98a8120d756d78b3c121c3
      https://github.com/wesnoth/wesnoth/commit/c980ffc74febfd9f5e98a8120d756d78b3c121c3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/end_credits.cpp
    M src/gui/dialogs/end_credits.hpp

  Log Message:
  -----------
  GUI2/End Credits: use DRAW event hook to scroll text instead of a timer

There's no visual difference between these methods since any of the scroll position changes wouldn't
take effect until the next draw anyway


  Commit: 7c90666bcc1ea5a5015481d038dc1fa37a467a00
      https://github.com/wesnoth/wesnoth/commit/7c90666bcc1ea5a5015481d038dc1fa37a467a00
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: cleaned up set/get_active_sorting_option functions

* Cleaner implementation of get_active_sorting_option.
* Validation step for the appropriate sorting toggle in set_active_sorting_option.
* Added some comments.


Compare: https://github.com/wesnoth/wesnoth/compare/53ffc2dbb25c...7c90666bcc1e