[Commits] [wesnoth/wesnoth] 6df924: GUI2/Settings: minor formatting cleanup

Fri Aug 25 08:54:39 UTC 2017

  Branch: refs/heads/some_gui2_refactoring
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6df92493ba6a89a46d966dc6a2e7a471ec357e15
      https://github.com/wesnoth/wesnoth/commit/6df92493ba6a89a46d966dc6a2e7a471ec357e15
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/settings.cpp

  Log Message:
  -----------
  GUI2/Settings: minor formatting cleanup

  Commit: 7ceb770bac2e54ee6319d40cded82e44765bcd6a
      https://github.com/wesnoth/wesnoth/commit/7ceb770bac2e54ee6319d40cded82e44765bcd6a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/window_builder.cpp
    M src/gui/core/window_builder.hpp

  Log Message:
  -----------
  GUI2/Window Builder: added function to generate a single widget instance with its builder

This will be used in some upcoming changes. The main benefit of this over directly initializing a new widget
object is any extra builder steps can also be executed.

I'm not entirely happy with the design, though, especially with having to specify both the type and type ID...

  Commit: df3496088aa1a8db9a19a45b2f98b2052d3d1fc3
      https://github.com/wesnoth/wesnoth/commit/df3496088aa1a8db9a19a45b2f98b2052d3d1fc3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/addon_list.cpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/button.cpp
    M src/gui/widgets/button.hpp
    M src/gui/widgets/chatbox.cpp
    M src/gui/widgets/chatbox.hpp
    M src/gui/widgets/container_base.cpp
    M src/gui/widgets/container_base.hpp
    M src/gui/widgets/drawing.cpp
    M src/gui/widgets/drawing.hpp
    M src/gui/widgets/horizontal_scrollbar.cpp
    M src/gui/widgets/horizontal_scrollbar.hpp
    M src/gui/widgets/image.cpp
    M src/gui/widgets/image.hpp
    M src/gui/widgets/label.cpp
    M src/gui/widgets/label.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/minimap.cpp
    M src/gui/widgets/minimap.hpp
    M src/gui/widgets/multi_page.cpp
    M src/gui/widgets/multi_page.hpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp
    M src/gui/widgets/panel.cpp
    M src/gui/widgets/panel.hpp
    M src/gui/widgets/password_box.cpp
    M src/gui/widgets/password_box.hpp
    M src/gui/widgets/progress_bar.cpp
    M src/gui/widgets/progress_bar.hpp
    M src/gui/widgets/repeating_button.cpp
    M src/gui/widgets/repeating_button.hpp
    M src/gui/widgets/scroll_label.cpp
    M src/gui/widgets/scroll_label.hpp
    M src/gui/widgets/scrollbar.cpp
    M src/gui/widgets/scrollbar.hpp
    M src/gui/widgets/scrollbar_container.cpp
    M src/gui/widgets/scrollbar_container.hpp
    M src/gui/widgets/scrollbar_panel.cpp
    M src/gui/widgets/scrollbar_panel.hpp
    M src/gui/widgets/size_lock.cpp
    M src/gui/widgets/size_lock.hpp
    M src/gui/widgets/slider.cpp
    M src/gui/widgets/slider.hpp
    M src/gui/widgets/spacer.cpp
    M src/gui/widgets/spacer.hpp
    M src/gui/widgets/stacked_widget.cpp
    M src/gui/widgets/stacked_widget.hpp
    M src/gui/widgets/styled_widget.cpp
    M src/gui/widgets/styled_widget.hpp
    M src/gui/widgets/text_box.cpp
    M src/gui/widgets/text_box.hpp
    M src/gui/widgets/text_box_base.cpp
    M src/gui/widgets/text_box_base.hpp
    M src/gui/widgets/toggle_button.cpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/unit_preview_pane.cpp
    M src/gui/widgets/unit_preview_pane.hpp
    M src/gui/widgets/vertical_scrollbar.cpp
    M src/gui/widgets/vertical_scrollbar.hpp
    M src/gui/widgets/window.cpp

  Log Message:
  -----------
  GUI2: refactored widget initialization process

Essentially, this utilizes the second styled_widget overload that takes a builder reference to allow widgets
to initialize themselves without the extra init_control call. It also removes the need for extra functions such
as styled_widget::load_config_extra or styled_widget::init since the widget definition config and canvases are
loaded in the styled_widget ctor. Any code from the uses of the former function were moved either to widget
builders or their ctors.

  Commit: 709ea279b3e74da6f3bfeffe1d123c0df27cc24e
      https://github.com/wesnoth/wesnoth/commit/709ea279b3e74da6f3bfeffe1d123c0df27cc24e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/scrollbar.hpp
    M src/gui/widgets/slider.cpp

  Log Message:
  -----------
  GUI2: prevented Scrollbar (and by extension Slider) step size from being set to 0

This can potentially cause division-by-0 crashes.

  Commit: ad07ec58f49aa2f17266fe2e99dec8fc01d11b78
      https://github.com/wesnoth/wesnoth/commit/ad07ec58f49aa2f17266fe2e99dec8fc01d11b78
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/window_builder.cpp
    M src/gui/widgets/window.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2/Window: pass definition pointer to ctor instead of individual arguments

  Commit: e9651c5bd50c0fb93612632336bc3d83cdf50802
      https://github.com/wesnoth/wesnoth/commit/e9651c5bd50c0fb93612632336bc3d83cdf50802
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/register_widget.hpp
    M src/gui/core/window_builder.hpp

  Log Message:
  -----------
  GUI2/Window Builder: removed build_widget function and used std::make_shared directly

This function's name was rather misleading. It didn't actually build a widget, just created a an
object (usually a builder, as it was utilized in REGISTER_WIDGET) with the config argument as its
ctor parameters.

Lamdas render the need of a separate function to pass as an std::function argument obsolete.

  Commit: f9c2dbe30517aa778f3d74112f797e3a3439ec91
      https://github.com/wesnoth/wesnoth/commit/f9c2dbe30517aa778f3d74112f797e3a3439ec91
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/window_builder.hpp

  Log Message:
  -----------
  GUI2/Window Builder: added comment clarifying Window how resolution options are used

  Commit: 3b4b7b93dcb63407bb0866cfea1cc10da594bd9c
      https://github.com/wesnoth/wesnoth/commit/3b4b7b93dcb63407bb0866cfea1cc10da594bd9c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/register_widget.hpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/button.cpp
    M src/gui/widgets/button.hpp
    M src/gui/widgets/chatbox.cpp
    M src/gui/widgets/chatbox.hpp
    M src/gui/widgets/drawing.cpp
    M src/gui/widgets/drawing.hpp
    M src/gui/widgets/horizontal_scrollbar.cpp
    M src/gui/widgets/horizontal_scrollbar.hpp
    M src/gui/widgets/image.cpp
    M src/gui/widgets/image.hpp
    M src/gui/widgets/label.cpp
    M src/gui/widgets/label.hpp
    M src/gui/widgets/list.cpp
    M src/gui/widgets/list.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/matrix.cpp
    M src/gui/widgets/matrix.hpp
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/minimap.cpp
    M src/gui/widgets/minimap.hpp
    M src/gui/widgets/multi_page.cpp
    M src/gui/widgets/multi_page.hpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp
    M src/gui/widgets/panel.cpp
    M src/gui/widgets/panel.hpp
    M src/gui/widgets/progress_bar.cpp
    M src/gui/widgets/progress_bar.hpp
    M src/gui/widgets/repeating_button.cpp
    M src/gui/widgets/repeating_button.hpp
    M src/gui/widgets/scroll_label.cpp
    M src/gui/widgets/scroll_label.hpp
    M src/gui/widgets/scrollbar_panel.cpp
    M src/gui/widgets/scrollbar_panel.hpp
    M src/gui/widgets/size_lock.hpp
    M src/gui/widgets/slider.cpp
    M src/gui/widgets/slider.hpp
    M src/gui/widgets/spacer.cpp
    M src/gui/widgets/spacer.hpp
    M src/gui/widgets/stacked_widget.cpp
    M src/gui/widgets/stacked_widget.hpp
    M src/gui/widgets/text_box.cpp
    M src/gui/widgets/text_box.hpp
    M src/gui/widgets/toggle_button.cpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/unit_preview_pane.cpp
    M src/gui/widgets/unit_preview_pane.hpp
    M src/gui/widgets/vertical_scrollbar.cpp
    M src/gui/widgets/vertical_scrollbar.hpp
    M src/gui/widgets/window.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2: allow REGISTER_WIDGET to implement get_control_type overrides

This is similar to what REGISER_WINDOW does with window_id().

Excludes the following class instances since they are not registered with REGISTER_WIDGET:
* tree_view_node
* scrollbar_container
* password_box (uses REGISTER_WIDGET3)

  Commit: a85137e433b53fb401646c119997f0f14933e57a
      https://github.com/wesnoth/wesnoth/commit/a85137e433b53fb401646c119997f0f14933e57a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/event/distributor.cpp
    M src/gui/core/window_builder.cpp
    M src/gui/widgets/window.cpp

  Log Message:
  -----------
  GUI2: don't use `0` to initialize nullptrs

  Commit: 93d2e8bd528b990a20ef7b2d42e576061f1d1177
      https://github.com/wesnoth/wesnoth/commit/93d2e8bd528b990a20ef7b2d42e576061f1d1177
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/tests/gui/iterator.cpp

  Log Message:
  -----------
  Fixup tests for ea15d45

  Commit: 2325092cf270906265a7008183db09a63f7be391
      https://github.com/wesnoth/wesnoth/commit/2325092cf270906265a7008183db09a63f7be391
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/status_label_helper.hpp

  Log Message:
  -----------
  GUI2/Status Label Helper: minor cleanup and added documentation

Renamed default_value_getter so it can be used outside the context of this class without being
confusing.

  Commit: c27aa6e248d72a7099cfe6004889b62242031d32
      https://github.com/wesnoth/wesnoth/commit/c27aa6e248d72a7099cfe6004889b62242031d32
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/editor/generator_settings.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/status_label_helper.hpp

  Log Message:
  -----------
  GUI2/Status Label Helper: take source containing widget as a pointer

They were only used in the context of pointers anyway,

  Commit: 04bfecfe2dacf3ee4b12394545ad4a02ec5c3361
      https://github.com/wesnoth/wesnoth/commit/04bfecfe2dacf3ee4b12394545ad4a02ec5c3361
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  GUI2/Preferences Dialog: use standard status label value getters instead of lambdas where possible

Only reason I was using lambdas was since I needed to specify the fourth argument. I didn't realize I
could just bind the default value getters, especially since the functionality was equivalent.

Menu buttons can't use them yet.

  Commit: da617e73f49ac271d458cc1290c4badfd1ea8c27
      https://github.com/wesnoth/wesnoth/commit/da617e73f49ac271d458cc1290c4badfd1ea8c27
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: move some common code for key handling to its own function

  Commit: 2fd098fd971bafbc0120662f29fbfb090ee93421
      https://github.com/wesnoth/wesnoth/commit/2fd098fd971bafbc0120662f29fbfb090ee93421
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: fire NOTIFY_MODIFIED events where callback_value_changed_ is called

This is the beginning of an effort to finish converting the event callbacks to signal handles instead
of function callbacks.

  Commit: 075b1590a285ddc40ea40ce5d3828c8ec6e1c77a
      https://github.com/wesnoth/wesnoth/commit/075b1590a285ddc40ea40ce5d3828c8ec6e1c77a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/core_selection.cpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/editor/generate_map.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/game_load.cpp
    M src/gui/dialogs/game_stats.cpp
    M src/gui/dialogs/game_version.cpp
    M src/gui/dialogs/lobby/lobby.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/mp_change_control.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/unit_advance.cpp
    M src/gui/dialogs/unit_create.cpp
    M src/gui/dialogs/unit_list.cpp
    M src/gui/dialogs/unit_recall.cpp
    M src/gui/dialogs/unit_recruit.cpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/chatbox.cpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  GUI2: use signal handlers for listbox event handling

This affects uses of both set_callback_item_change and set_callback_value_change.
Finally we get rid of most of the conditional GUI2_EXPERIMENTAL_LISTBOX handler setups. \o/

[ci skip]

  Commit: 774e4cc7629cb1c1dc8ae4be311368f4460265c7
      https://github.com/wesnoth/wesnoth/commit/774e4cc7629cb1c1dc8ae4be311368f4460265c7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: removed callback interface

Do note the removal of the extra precondition of a valid callback before NOTIFED_MODIFED events
were fired in two cases is probably a bugfix on aaa5e0b5e.

  Commit: 85ed8a81afc7bb764fe534b1766c7affb5243080
      https://github.com/wesnoth/wesnoth/commit/85ed8a81afc7bb764fe534b1766c7affb5243080
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/toggle_button.cpp

  Log Message:
  -----------
  GUI2/Toggle Button: fire NOTIFY_MODIFIED when setting value

This matches other widget such as the toggle_panel.

  Commit: 50410a9fffe7828094be210fa62e4e0419c9aba6
      https://github.com/wesnoth/wesnoth/commit/50410a9fffe7828094be210fa62e4e0419c9aba6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/auxiliary/field.hpp

  Log Message:
  -----------
  GUI2/Field: minor mostly cosmetic cleanup

  Commit: 1b801182c075c098fc5f6ab1bd8ae81aa9d6d9a4
      https://github.com/wesnoth/wesnoth/commit/1b801182c075c098fc5f6ab1bd8ae81aa9d6d9a4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.cpp
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2/Dispatcher: changed dispatcher signals to take a widget reference as a first parameter

This fixes an issue where functions taking `widget` as a parameter couldn't be bound to a signal function
with the first argument passed via placeholder since `std::bind` requires arguments match exactly when using
the placeholders.

The dispatcher's `this` was cast to `widget` before the signal functions were fired anyway, so this doesn't
really constitute any functional change.

  Commit: 729e66e40a440a8d665c675dc11ff672553747e5
      https://github.com/wesnoth/wesnoth/commit/729e66e40a440a8d665c675dc11ff672553747e5
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/auxiliary/field.hpp
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/editor/resize_map.cpp
    M src/gui/dialogs/label_settings.cpp
    M src/gui/dialogs/lobby/lobby.cpp
    M src/gui/dialogs/lobby/lobby.hpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/generator.cpp
    M src/gui/widgets/group.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/toggle_button.cpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  GUI2: convert uses of 'state changed' callbacks to NOTIFY_MODIFIED signal handlers

  Commit: 7f265e46b230a0f08d8d1eb32b3ef2c269799351
      https://github.com/wesnoth/wesnoth/commit/7f265e46b230a0f08d8d1eb32b3ef2c269799351
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/selectable_item.hpp
    M src/gui/widgets/toggle_button.cpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp

  Log Message:
  -----------
  GUI2: removed state_changed callback interface from selected_item child classes

I left the callbacks in tree_view_node for now since they don't really inherit from selected_item and
I need to make it fire NOTIFY_MODIFED correctly and decide if I want to keep the state to-fold/to-unfold
distinctions.

  Commit: 942cf18433e65b2392af8b7d98c4f94862e6047a
      https://github.com/wesnoth/wesnoth/commit/942cf18433e65b2392af8b7d98c4f94862e6047a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/unit_create.cpp
    M src/gui/dialogs/unit_create.hpp

  Log Message:
  -----------
  GUI2/Unit Create: show type details based on currently selected gender

  Commit: 6368ee4efd00dc4c8ba16800cd36b9560336b3cf
      https://github.com/wesnoth/wesnoth/commit/6368ee4efd00dc4c8ba16800cd36b9560336b3cf
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2/Dispatcher: added signal handler register helper for double click events

Mostly because I needed to register it in the back_post_child queue position to work.
See doc comment for more details.

  Commit: 6a1b4fdf539c74cefcb09d13d3b831ffcdacc5ed
      https://github.com/wesnoth/wesnoth/commit/6a1b4fdf539c74cefcb09d13d3b831ffcdacc5ed
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/lobby/lobby.cpp

  Log Message:
  -----------
  GUI2/MP Lobby: convert two uses of set_callback_mouse_left_double_click to signal handlers

  Commit: 7b7ece8af949c83faf1cd027ea74e137d2cecd7c
      https://github.com/wesnoth/wesnoth/commit/7b7ece8af949c83faf1cd027ea74e137d2cecd7c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp

  Log Message:
  -----------
  GUI2/Toggle Panel: removed callback_mouse_left_double_click interface

  Commit: ae659547c02c83cf47affb7a6cc3ae12a22a04df
      https://github.com/wesnoth/wesnoth/commit/ae659547c02c83cf47affb7a6cc3ae12a22a04df
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/text_box.cpp

  Log Message:
  -----------
  GUI2/Text Box: set font size and style in ctor (fixes issue with password box)

Since the password box had its own builder, this wasn't getting called, leading to cursor offset issues.
I'm not sure this is the best place to have it, but it works for now.

  Commit: ff98bc4c9b21654d58644a8e17fc77a68df1535a
      https://github.com/wesnoth/wesnoth/commit/ff98bc4c9b21654d58644a8e17fc77a68df1535a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  GUI2/Preferences Dialog: added more explanatory comments about binding lambdas

[ci skip]

  Commit: f125ab9384b08dfc272ee359d6f0110fa12fb5ec
      https://github.com/wesnoth/wesnoth/commit/f125ab9384b08dfc272ee359d6f0110fa12fb5ec
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M data/gui/window/unit_advance.cfg

  Log Message:
  -----------
  GUI2/Unit Advance: allowed text formatting in advancement name field (closes #1914)

  Commit: 759ff4b6f1eae916bd1ec9c84babba5f5d36642e
      https://github.com/wesnoth/wesnoth/commit/759ff4b6f1eae916bd1ec9c84babba5f5d36642e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.hpp
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.hpp
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  Standardized my comment signature date format (using ISO 8601)

[ci skip]

  Commit: 28698fc4d471c99731321aa23cb7ed6aaa7beadd
      https://github.com/wesnoth/wesnoth/commit/28698fc4d471c99731321aa23cb7ed6aaa7beadd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.cpp
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2/Dispatcher: removed inline specifier from [dis]connect_signal_* functions

This isn't really necessary (the compiler does a fine job of knowing when something should be inlined)
and increases binary size.

  Commit: 6b73ba5230980eb54f280a5c5e08be58b3d70e58
      https://github.com/wesnoth/wesnoth/commit/6b73ba5230980eb54f280a5c5e08be58b3d70e58
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: used std::less instead of custom comparison function

  Commit: e0bf0e45e1d82d0dc345827009d129389a4980a3
      https://github.com/wesnoth/wesnoth/commit/e0bf0e45e1d82d0dc345827009d129389a4980a3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/generator.hpp
    M src/gui/widgets/generator_private.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2: drop t-prefix from order_func typedef

  Commit: 0a053e8b9b1f7bca60c3505b9a5cfc8e9d7fbf1d
      https://github.com/wesnoth/wesnoth/commit/0a053e8b9b1f7bca60c3505b9a5cfc8e9d7fbf1d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: formatting cleanup

  Commit: 4b0501a3a053314b1d7e6be00883ec4efa982b72
      https://github.com/wesnoth/wesnoth/commit/4b0501a3a053314b1d7e6be00883ec4efa982b72
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/styled_widget.hpp

  Log Message:
  -----------
  GUI2/Styled Widget: removed now-unnecessary friend declaration for the window class

The refactoring referred to in the comments has now been done (ea15d450fd9).

  Commit: 19b937a44100dfc4928485cf2bcfb1bcbc9aaa74
      https://github.com/wesnoth/wesnoth/commit/19b937a44100dfc4928485cf2bcfb1bcbc9aaa74
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: pass list grid builder directly to constructor

Also gave the `select` argument a default value and re-ordered the placement type to be the second argument.

  Commit: 6f59f5e4bc2e91a1d2e8a477bf06f9b99f53ca65
      https://github.com/wesnoth/wesnoth/commit/6f59f5e4bc2e91a1d2e8a477bf06f9b99f53ca65
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/generator.cpp

  Log Message:
  -----------
  GUI2/Generator: use static_assert to have actual compile-time assertions

  Commit: aca9e9434021b0314c2691ffdf8629c67cdc7d80
      https://github.com/wesnoth/wesnoth/commit/aca9e9434021b0314c2691ffdf8629c67cdc7d80
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/generator.cpp
    M src/gui/widgets/generator_private.hpp

  Log Message:
  -----------
  GUI2/Generator: formatting cleanup

  Commit: 38466681b6ba29a6ed3d92c46ea7a2e37c83d0fb
      https://github.com/wesnoth/wesnoth/commit/38466681b6ba29a6ed3d92c46ea7a2e37c83d0fb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/core/event/handler.cpp
    M src/gui/widgets/window.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2/Window: handle CLOSE_WINDOW event with a signal handler

  Commit: 8ec19db1d8ac8f98eea7aa4b9bda0f998d7dd331
      https://github.com/wesnoth/wesnoth/commit/8ec19db1d8ac8f98eea7aa4b9bda0f998d7dd331
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/tests/gui/visitor.cpp

  Log Message:
  -----------
  More test fixup

  Commit: 7ce090a98fa2ffa3c0467e4d2bde52cc9b7173a0
      https://github.com/wesnoth/wesnoth/commit/7ce090a98fa2ffa3c0467e4d2bde52cc9b7173a0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/text_box_base.cpp

  Log Message:
  -----------
  GUI2/Text Box Base: made ctrl+a select all text

Previously it was an alias for HOME, which is unintuitive and rather useless.

  Commit: fecabf3dc515f2565d22e3a576fd22538849d4d6
      https://github.com/wesnoth/wesnoth/commit/fecabf3dc515f2565d22e3a576fd22538849d4d6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/loading_screen.cpp

  Log Message:
  -----------
  GUI2/Loading Screen: formatting cleanup

  Commit: f10253b4a503680661d7dd8d5acc975e3803e580
      https://github.com/wesnoth/wesnoth/commit/f10253b4a503680661d7dd8d5acc975e3803e580
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/editor/custom_tod.cpp
    M src/gui/dialogs/editor/edit_label.cpp
    M src/gui/dialogs/editor/edit_scenario.cpp
    M src/gui/dialogs/editor/edit_side.cpp
    M src/gui/dialogs/multiplayer/mp_login.cpp

  Log Message:
  -----------
  GUI2: require existence of all widgets added to tab order

Not sure if window::add_to_tab_order should take a reference in this case.

  Commit: b5731fbe527507bc3e3e87b447d7dffa066d1869
      https://github.com/wesnoth/wesnoth/commit/b5731fbe527507bc3e3e87b447d7dffa066d1869
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/chat_log.cpp
    M src/gui/dialogs/editor/edit_side.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/game_cache_options.cpp
    M src/gui/dialogs/loading_screen.cpp
    M src/gui/dialogs/lobby/player_info.cpp
    M src/gui/dialogs/lua_interpreter.cpp
    M src/gui/dialogs/multiplayer/mp_alerts_options.cpp
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  GUI2: use find_widget overload returning a pointer when applicable

Instead of taking address-of the reference version.

  Commit: c572cd2f6baec84025d11a7cc21248a6a3cab874
      https://github.com/wesnoth/wesnoth/commit/c572cd2f6baec84025d11a7cc21248a6a3cab874
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/dialogs/end_credits.cpp
    M src/gui/dialogs/end_credits.hpp

  Log Message:
  -----------
  GUI2/End Credits: use DRAW event hook to scroll text instead of a timer

There's no visual difference between these methods since any of the scroll position changes wouldn't
take effect until the next draw anyway

  Commit: dc008bf3ccf874cd88a90575f0c4415deadb2e29
      https://github.com/wesnoth/wesnoth/commit/dc008bf3ccf874cd88a90575f0c4415deadb2e29
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: cleaned up set/get_active_sorting_option functions

* Cleaner implementation of get_active_sorting_option.
* Added some comments.

  Commit: 058ffd5ba43c5794cb70eb416fd8baa49f6b9f13
      https://github.com/wesnoth/wesnoth/commit/058ffd5ba43c5794cb70eb416fd8baa49f6b9f13
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: use an enum for update_visible_area_on_key_event's argument

  Commit: 0230d467b65ea9f4c360252107dc52183dd2a0a1
      https://github.com/wesnoth/wesnoth/commit/0230d467b65ea9f4c360252107dc52183dd2a0a1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-25 (Fri, 25 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: pass list_item_clicked directly to generator w/o intermediary helper

Compare: https://github.com/wesnoth/wesnoth/compare/23fad6d44ce7...0230d467b65e