[Commits] [wesnoth/wesnoth] da2882: GUI2/Settings: minor formatting cleanup

Fri Aug 25 23:49:09 UTC 2017

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: da28824694bcd0086708a9f27cafaef8c78fb230
      https://github.com/wesnoth/wesnoth/commit/da28824694bcd0086708a9f27cafaef8c78fb230
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/settings.cpp

  Log Message:
  -----------
  GUI2/Settings: minor formatting cleanup

  Commit: d78158d2121f72f6854eb3a40471a34429256db7
      https://github.com/wesnoth/wesnoth/commit/d78158d2121f72f6854eb3a40471a34429256db7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/window_builder.cpp
    M src/gui/core/window_builder.hpp

  Log Message:
  -----------
  GUI2/Window Builder: added function to generate a single widget instance with its builder

This will be used in some upcoming changes. The main benefit of this over directly initializing a new widget
object is any extra builder steps can also be executed.

I'm not entirely happy with the design, though, especially with having to specify both the type and type ID...

  Commit: a87132ab6b9b87cab254c0429fcffe529b974876
      https://github.com/wesnoth/wesnoth/commit/a87132ab6b9b87cab254c0429fcffe529b974876
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/addon_list.cpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/button.cpp
    M src/gui/widgets/button.hpp
    M src/gui/widgets/chatbox.cpp
    M src/gui/widgets/chatbox.hpp
    M src/gui/widgets/container_base.cpp
    M src/gui/widgets/container_base.hpp
    M src/gui/widgets/drawing.cpp
    M src/gui/widgets/drawing.hpp
    M src/gui/widgets/horizontal_scrollbar.cpp
    M src/gui/widgets/horizontal_scrollbar.hpp
    M src/gui/widgets/image.cpp
    M src/gui/widgets/image.hpp
    M src/gui/widgets/label.cpp
    M src/gui/widgets/label.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/minimap.cpp
    M src/gui/widgets/minimap.hpp
    M src/gui/widgets/multi_page.cpp
    M src/gui/widgets/multi_page.hpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp
    M src/gui/widgets/panel.cpp
    M src/gui/widgets/panel.hpp
    M src/gui/widgets/password_box.cpp
    M src/gui/widgets/password_box.hpp
    M src/gui/widgets/progress_bar.cpp
    M src/gui/widgets/progress_bar.hpp
    M src/gui/widgets/repeating_button.cpp
    M src/gui/widgets/repeating_button.hpp
    M src/gui/widgets/scroll_label.cpp
    M src/gui/widgets/scroll_label.hpp
    M src/gui/widgets/scrollbar.cpp
    M src/gui/widgets/scrollbar.hpp
    M src/gui/widgets/scrollbar_container.cpp
    M src/gui/widgets/scrollbar_container.hpp
    M src/gui/widgets/scrollbar_panel.cpp
    M src/gui/widgets/scrollbar_panel.hpp
    M src/gui/widgets/size_lock.cpp
    M src/gui/widgets/size_lock.hpp
    M src/gui/widgets/slider.cpp
    M src/gui/widgets/slider.hpp
    M src/gui/widgets/spacer.cpp
    M src/gui/widgets/spacer.hpp
    M src/gui/widgets/stacked_widget.cpp
    M src/gui/widgets/stacked_widget.hpp
    M src/gui/widgets/styled_widget.cpp
    M src/gui/widgets/styled_widget.hpp
    M src/gui/widgets/text_box.cpp
    M src/gui/widgets/text_box.hpp
    M src/gui/widgets/text_box_base.cpp
    M src/gui/widgets/text_box_base.hpp
    M src/gui/widgets/toggle_button.cpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/unit_preview_pane.cpp
    M src/gui/widgets/unit_preview_pane.hpp
    M src/gui/widgets/vertical_scrollbar.cpp
    M src/gui/widgets/vertical_scrollbar.hpp
    M src/gui/widgets/window.cpp

  Log Message:
  -----------
  GUI2: refactored widget initialization process

Essentially, this utilizes the second styled_widget overload that takes a builder reference to allow widgets
to initialize themselves without the extra init_control call. It also removes the need for extra functions such
as styled_widget::load_config_extra or styled_widget::init since the widget definition config and canvases are
loaded in the styled_widget ctor. Any code from the uses of the former function were moved either to widget
builders or their ctors.

  Commit: e0e76c4f1575dc9dfd5f6856d079329bd48669eb
      https://github.com/wesnoth/wesnoth/commit/e0e76c4f1575dc9dfd5f6856d079329bd48669eb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/scrollbar.hpp
    M src/gui/widgets/slider.cpp

  Log Message:
  -----------
  GUI2: prevented Scrollbar (and by extension Slider) step size from being set to 0

This can potentially cause division-by-0 crashes.

  Commit: b5c42234d2c2ae4f98e7d8298b73746fd66bae27
      https://github.com/wesnoth/wesnoth/commit/b5c42234d2c2ae4f98e7d8298b73746fd66bae27
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/window_builder.cpp
    M src/gui/widgets/window.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2/Window: pass definition pointer to ctor instead of individual arguments

  Commit: 7e5e7b8b17e7c665feb8830a3740ba9b71c6da1a
      https://github.com/wesnoth/wesnoth/commit/7e5e7b8b17e7c665feb8830a3740ba9b71c6da1a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/register_widget.hpp
    M src/gui/core/window_builder.hpp

  Log Message:
  -----------
  GUI2/Window Builder: removed build_widget function and used std::make_shared directly

This function's name was rather misleading. It didn't actually build a widget, just created a an
object (usually a builder, as it was utilized in REGISTER_WIDGET) with the config argument as its
ctor parameters.

Lamdas render the need of a separate function to pass as an std::function argument obsolete.

  Commit: 71f97044ccdb0ea1b757e021fd38b6afdbfbfc4f
      https://github.com/wesnoth/wesnoth/commit/71f97044ccdb0ea1b757e021fd38b6afdbfbfc4f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/window_builder.hpp

  Log Message:
  -----------
  GUI2/Window Builder: added comment clarifying Window how resolution options are used

  Commit: bb5e283d402d9f3de28eab8e325a06e09a7e4a0a
      https://github.com/wesnoth/wesnoth/commit/bb5e283d402d9f3de28eab8e325a06e09a7e4a0a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/register_widget.hpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/button.cpp
    M src/gui/widgets/button.hpp
    M src/gui/widgets/chatbox.cpp
    M src/gui/widgets/chatbox.hpp
    M src/gui/widgets/drawing.cpp
    M src/gui/widgets/drawing.hpp
    M src/gui/widgets/horizontal_scrollbar.cpp
    M src/gui/widgets/horizontal_scrollbar.hpp
    M src/gui/widgets/image.cpp
    M src/gui/widgets/image.hpp
    M src/gui/widgets/label.cpp
    M src/gui/widgets/label.hpp
    M src/gui/widgets/list.cpp
    M src/gui/widgets/list.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp
    M src/gui/widgets/matrix.cpp
    M src/gui/widgets/matrix.hpp
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/minimap.cpp
    M src/gui/widgets/minimap.hpp
    M src/gui/widgets/multi_page.cpp
    M src/gui/widgets/multi_page.hpp
    M src/gui/widgets/multimenu_button.cpp
    M src/gui/widgets/multimenu_button.hpp
    M src/gui/widgets/panel.cpp
    M src/gui/widgets/panel.hpp
    M src/gui/widgets/progress_bar.cpp
    M src/gui/widgets/progress_bar.hpp
    M src/gui/widgets/repeating_button.cpp
    M src/gui/widgets/repeating_button.hpp
    M src/gui/widgets/scroll_label.cpp
    M src/gui/widgets/scroll_label.hpp
    M src/gui/widgets/scrollbar_panel.cpp
    M src/gui/widgets/scrollbar_panel.hpp
    M src/gui/widgets/size_lock.hpp
    M src/gui/widgets/slider.cpp
    M src/gui/widgets/slider.hpp
    M src/gui/widgets/spacer.cpp
    M src/gui/widgets/spacer.hpp
    M src/gui/widgets/stacked_widget.cpp
    M src/gui/widgets/stacked_widget.hpp
    M src/gui/widgets/text_box.cpp
    M src/gui/widgets/text_box.hpp
    M src/gui/widgets/toggle_button.cpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp
    M src/gui/widgets/tree_view.cpp
    M src/gui/widgets/tree_view.hpp
    M src/gui/widgets/unit_preview_pane.cpp
    M src/gui/widgets/unit_preview_pane.hpp
    M src/gui/widgets/vertical_scrollbar.cpp
    M src/gui/widgets/vertical_scrollbar.hpp
    M src/gui/widgets/window.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2: allow REGISTER_WIDGET to implement get_control_type overrides

This is similar to what REGISER_WINDOW does with window_id().

Excludes the following class instances since they are not registered with REGISTER_WIDGET:
* tree_view_node
* scrollbar_container
* password_box (uses REGISTER_WIDGET3)

  Commit: 39043fb940d7acba7cea43e24dd1df3919a0d342
      https://github.com/wesnoth/wesnoth/commit/39043fb940d7acba7cea43e24dd1df3919a0d342
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/event/distributor.cpp
    M src/gui/core/window_builder.cpp
    M src/gui/widgets/window.cpp

  Log Message:
  -----------
  GUI2: don't use `0` to initialize nullptrs

  Commit: 665246525f4756cb35af4798a50c4a0598af13ea
      https://github.com/wesnoth/wesnoth/commit/665246525f4756cb35af4798a50c4a0598af13ea
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/tests/gui/iterator.cpp

  Log Message:
  -----------
  Fixup tests for ea15d45

  Commit: 86e853b5f962b4500b5a199d91e19faba58ff24a
      https://github.com/wesnoth/wesnoth/commit/86e853b5f962b4500b5a199d91e19faba58ff24a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/status_label_helper.hpp

  Log Message:
  -----------
  GUI2/Status Label Helper: minor cleanup and added documentation

Renamed default_value_getter so it can be used outside the context of this class without being
confusing.

  Commit: 573268a9b3189d2e2bd275b26521237bdf065519
      https://github.com/wesnoth/wesnoth/commit/573268a9b3189d2e2bd275b26521237bdf065519
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/editor/generator_settings.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/status_label_helper.hpp

  Log Message:
  -----------
  GUI2/Status Label Helper: take source containing widget as a pointer

They were only used in the context of pointers anyway,

  Commit: 994742b90f7d3909143556fa21c7d6b3e1dec653
      https://github.com/wesnoth/wesnoth/commit/994742b90f7d3909143556fa21c7d6b3e1dec653
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  GUI2/Preferences Dialog: use standard status label value getters instead of lambdas where possible

Only reason I was using lambdas was since I needed to specify the fourth argument. I didn't realize I
could just bind the default value getters, especially since the functionality was equivalent.

Menu buttons can't use them yet.

  Commit: 9438706560943ddbae968632b4660d278917bdfd
      https://github.com/wesnoth/wesnoth/commit/9438706560943ddbae968632b4660d278917bdfd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: move some common code for key handling to its own function

  Commit: 80f5af2e79154d2576aeb053d54f47c3dd82fbfc
      https://github.com/wesnoth/wesnoth/commit/80f5af2e79154d2576aeb053d54f47c3dd82fbfc
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: fire NOTIFY_MODIFIED events where callback_value_changed_ is called

This is the beginning of an effort to finish converting the event callbacks to signal handles instead
of function callbacks.

  Commit: e58bbd7a20dfe492e16d967bf9e5951a92dc5c1c
      https://github.com/wesnoth/wesnoth/commit/e58bbd7a20dfe492e16d967bf9e5951a92dc5c1c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/core_selection.cpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/editor/generate_map.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/game_load.cpp
    M src/gui/dialogs/game_stats.cpp
    M src/gui/dialogs/game_version.cpp
    M src/gui/dialogs/lobby/lobby.cpp
    M src/gui/dialogs/multiplayer/faction_select.cpp
    M src/gui/dialogs/multiplayer/mp_change_control.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/dialogs/statistics_dialog.cpp
    M src/gui/dialogs/unit_advance.cpp
    M src/gui/dialogs/unit_create.cpp
    M src/gui/dialogs/unit_list.cpp
    M src/gui/dialogs/unit_recall.cpp
    M src/gui/dialogs/unit_recruit.cpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/chatbox.cpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  GUI2: use signal handlers for listbox event handling

This affects uses of both set_callback_item_change and set_callback_value_change.
Finally we get rid of most of the conditional GUI2_EXPERIMENTAL_LISTBOX handler setups. \o/

[ci skip]

  Commit: d7de5a6ade129b4276c6396f16176ca754f97fe2
      https://github.com/wesnoth/wesnoth/commit/d7de5a6ade129b4276c6396f16176ca754f97fe2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: removed callback interface

Do note the removal of the extra precondition of a valid callback before NOTIFED_MODIFED events
were fired in two cases is probably a bugfix on aaa5e0b5e.

  Commit: 6b7b922bc7becf897d144621518ce2f07819cf8e
      https://github.com/wesnoth/wesnoth/commit/6b7b922bc7becf897d144621518ce2f07819cf8e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/toggle_button.cpp

  Log Message:
  -----------
  GUI2/Toggle Button: fire NOTIFY_MODIFIED when setting value

This matches other widget such as the toggle_panel.

  Commit: 6d4b092f570a3fcc8fe0fcfb94d035aa4af881a4
      https://github.com/wesnoth/wesnoth/commit/6d4b092f570a3fcc8fe0fcfb94d035aa4af881a4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/auxiliary/field.hpp

  Log Message:
  -----------
  GUI2/Field: minor mostly cosmetic cleanup

  Commit: f7a2b5112e392784c79ba8321f61e6419ac2f375
      https://github.com/wesnoth/wesnoth/commit/f7a2b5112e392784c79ba8321f61e6419ac2f375
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.cpp
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2/Dispatcher: changed dispatcher signals to take a widget reference as a first parameter

This fixes an issue where functions taking `widget` as a parameter couldn't be bound to a signal function
with the first argument passed via placeholder since `std::bind` requires arguments match exactly when using
the placeholders.

The dispatcher's `this` was cast to `widget` before the signal functions were fired anyway, so this doesn't
really constitute any functional change.

  Commit: 2a1c1a81fcf1972a2dbf58c7115b70e1b2a461d3
      https://github.com/wesnoth/wesnoth/commit/2a1c1a81fcf1972a2dbf58c7115b70e1b2a461d3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/auxiliary/field.hpp
    M src/gui/dialogs/campaign_selection.cpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/editor/resize_map.cpp
    M src/gui/dialogs/label_settings.cpp
    M src/gui/dialogs/lobby/lobby.cpp
    M src/gui/dialogs/lobby/lobby.hpp
    M src/gui/dialogs/multiplayer/mp_create_game.cpp
    M src/gui/dialogs/multiplayer/mp_options_helper.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/gui/widgets/generator.cpp
    M src/gui/widgets/group.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/toggle_button.cpp
    M src/scripting/lua_gui2.cpp

  Log Message:
  -----------
  GUI2: convert uses of 'state changed' callbacks to NOTIFY_MODIFIED signal handlers

  Commit: d04c3f63f2497522b126c3632f29307ef6528e4f
      https://github.com/wesnoth/wesnoth/commit/d04c3f63f2497522b126c3632f29307ef6528e4f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/menu_button.cpp
    M src/gui/widgets/menu_button.hpp
    M src/gui/widgets/selectable_item.hpp
    M src/gui/widgets/toggle_button.cpp
    M src/gui/widgets/toggle_button.hpp
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp

  Log Message:
  -----------
  GUI2: removed state_changed callback interface from selected_item child classes

I left the callbacks in tree_view_node for now since they don't really inherit from selected_item and
I need to make it fire NOTIFY_MODIFED correctly and decide if I want to keep the state to-fold/to-unfold
distinctions.

  Commit: 8331cdb64ca05259dadbb458cbb4d4f8c212b21e
      https://github.com/wesnoth/wesnoth/commit/8331cdb64ca05259dadbb458cbb4d4f8c212b21e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/unit_create.cpp
    M src/gui/dialogs/unit_create.hpp

  Log Message:
  -----------
  GUI2/Unit Create: show type details based on currently selected gender

  Commit: b36e0476c6f1e2ed58386b3ee680763eb3eeb332
      https://github.com/wesnoth/wesnoth/commit/b36e0476c6f1e2ed58386b3ee680763eb3eeb332
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2/Dispatcher: added signal handler register helper for double click events

Mostly because I needed to register it in the back_post_child queue position to work.
See doc comment for more details.

  Commit: 20ecc9497fce12783de0f1e0e31aa2efbf5176a0
      https://github.com/wesnoth/wesnoth/commit/20ecc9497fce12783de0f1e0e31aa2efbf5176a0
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/lobby/lobby.cpp

  Log Message:
  -----------
  GUI2/MP Lobby: convert two uses of set_callback_mouse_left_double_click to signal handlers

  Commit: 2ee3425ad02c7f0f3b3410676bf004b673ace101
      https://github.com/wesnoth/wesnoth/commit/2ee3425ad02c7f0f3b3410676bf004b673ace101
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/toggle_panel.cpp
    M src/gui/widgets/toggle_panel.hpp

  Log Message:
  -----------
  GUI2/Toggle Panel: removed callback_mouse_left_double_click interface

  Commit: 5428606cd1a483107cffeb707e0cbfcd2520fcc1
      https://github.com/wesnoth/wesnoth/commit/5428606cd1a483107cffeb707e0cbfcd2520fcc1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/text_box.cpp

  Log Message:
  -----------
  GUI2/Text Box: set font size and style in ctor (fixes issue with password box)

Since the password box had its own builder, this wasn't getting called, leading to cursor offset issues.
I'm not sure this is the best place to have it, but it works for now.

  Commit: d92a528240e62fa78ddde64d85215a003625dacc
      https://github.com/wesnoth/wesnoth/commit/d92a528240e62fa78ddde64d85215a003625dacc
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  GUI2/Preferences Dialog: added more explanatory comments about binding lambdas

[ci skip]

  Commit: 84f3e79504d4722c6e09a377703073dcd7b790af
      https://github.com/wesnoth/wesnoth/commit/84f3e79504d4722c6e09a377703073dcd7b790af
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M data/gui/window/unit_advance.cfg

  Log Message:
  -----------
  GUI2/Unit Advance: allowed text formatting in advancement name field (closes #1914)

  Commit: d6a6ec1ea5cb633e0ac7f67bfd7bb22fa9b23c03
      https://github.com/wesnoth/wesnoth/commit/d6a6ec1ea5cb633e0ac7f67bfd7bb22fa9b23c03
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.hpp
    M src/gui/dialogs/addon/manager.cpp
    M src/gui/dialogs/drop_down_menu.cpp
    M src/gui/dialogs/multiplayer/mp_create_game.hpp
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  Standardized my comment signature date format (using ISO 8601)

[ci skip]

  Commit: 5f1695a46c63a111871cf12447de8ac6d8e4970c
      https://github.com/wesnoth/wesnoth/commit/5f1695a46c63a111871cf12447de8ac6d8e4970c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.cpp
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2/Dispatcher: removed inline specifier from [dis]connect_signal_* functions

This isn't really necessary (the compiler does a fine job of knowing when something should be inlined)
and increases binary size.

  Commit: 936a87ff1854211cc19370d2e2ec64f34f21b327
      https://github.com/wesnoth/wesnoth/commit/936a87ff1854211cc19370d2e2ec64f34f21b327
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: used std::less instead of custom comparison function

  Commit: 94ca31cb0a4bc77a4584e4d18fe0675aa041c72c
      https://github.com/wesnoth/wesnoth/commit/94ca31cb0a4bc77a4584e4d18fe0675aa041c72c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/generator.hpp
    M src/gui/widgets/generator_private.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2: drop t-prefix from order_func typedef

  Commit: 407486bfc48c313a892f4501a5b52cca82ebd464
      https://github.com/wesnoth/wesnoth/commit/407486bfc48c313a892f4501a5b52cca82ebd464
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: formatting cleanup

  Commit: 99c5cb0399ce25f559f012dec0ee42f223988ac7
      https://github.com/wesnoth/wesnoth/commit/99c5cb0399ce25f559f012dec0ee42f223988ac7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/styled_widget.hpp

  Log Message:
  -----------
  GUI2/Styled Widget: removed now-unnecessary friend declaration for the window class

The refactoring referred to in the comments has now been done (ea15d450fd9).

  Commit: b40d79d92dea89ab9ee7ac73c102294ce2b852ad
      https://github.com/wesnoth/wesnoth/commit/b40d79d92dea89ab9ee7ac73c102294ce2b852ad
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: pass list grid builder directly to constructor

Also gave the `select` argument a default value and re-ordered the placement type to be the second argument.

  Commit: 357087770752f75336f65355a207bbb28e4cb3a9
      https://github.com/wesnoth/wesnoth/commit/357087770752f75336f65355a207bbb28e4cb3a9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/generator.cpp

  Log Message:
  -----------
  GUI2/Generator: use static_assert to have actual compile-time assertions

  Commit: 23734c3aaa8c48f092a52d02b7ec42bf941d7170
      https://github.com/wesnoth/wesnoth/commit/23734c3aaa8c48f092a52d02b7ec42bf941d7170
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/generator.cpp
    M src/gui/widgets/generator_private.hpp

  Log Message:
  -----------
  GUI2/Generator: formatting cleanup

  Commit: 029e9360135260d37cf58d68e1d3301ed0dd3225
      https://github.com/wesnoth/wesnoth/commit/029e9360135260d37cf58d68e1d3301ed0dd3225
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/core/event/handler.cpp
    M src/gui/widgets/window.cpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  GUI2/Window: handle CLOSE_WINDOW event with a signal handler

  Commit: 2cf5ce0154cdcb38d2964f8b232a0b48c2d584ad
      https://github.com/wesnoth/wesnoth/commit/2cf5ce0154cdcb38d2964f8b232a0b48c2d584ad
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/tests/gui/visitor.cpp

  Log Message:
  -----------
  More test fixup

  Commit: 201fafd5ea2b55cc1b58f2b9632e7a1f1003510c
      https://github.com/wesnoth/wesnoth/commit/201fafd5ea2b55cc1b58f2b9632e7a1f1003510c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/text_box_base.cpp

  Log Message:
  -----------
  GUI2/Text Box Base: made ctrl+a select all text

Previously it was an alias for HOME, which is unintuitive and rather useless.

  Commit: 304702a0399392b5f49b78fe66ef1334860c39aa
      https://github.com/wesnoth/wesnoth/commit/304702a0399392b5f49b78fe66ef1334860c39aa
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/loading_screen.cpp

  Log Message:
  -----------
  GUI2/Loading Screen: formatting cleanup

  Commit: 79abf8006bbc631a18a0cb9f22fd1fa02b0dc6fc
      https://github.com/wesnoth/wesnoth/commit/79abf8006bbc631a18a0cb9f22fd1fa02b0dc6fc
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/editor/custom_tod.cpp
    M src/gui/dialogs/editor/edit_label.cpp
    M src/gui/dialogs/editor/edit_scenario.cpp
    M src/gui/dialogs/editor/edit_side.cpp
    M src/gui/dialogs/multiplayer/mp_login.cpp

  Log Message:
  -----------
  GUI2: require existence of all widgets added to tab order

Not sure if window::add_to_tab_order should take a reference in this case.

  Commit: 92cfaf431ec3fbf587e4b906c534a836280b4ea8
      https://github.com/wesnoth/wesnoth/commit/92cfaf431ec3fbf587e4b906c534a836280b4ea8
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/chat_log.cpp
    M src/gui/dialogs/editor/edit_side.cpp
    M src/gui/dialogs/file_dialog.cpp
    M src/gui/dialogs/game_cache_options.cpp
    M src/gui/dialogs/loading_screen.cpp
    M src/gui/dialogs/lobby/player_info.cpp
    M src/gui/dialogs/lua_interpreter.cpp
    M src/gui/dialogs/multiplayer/mp_alerts_options.cpp
    M src/gui/dialogs/preferences_dialog.cpp

  Log Message:
  -----------
  GUI2: use find_widget overload returning a pointer when applicable

Instead of taking address-of the reference version.

  Commit: 201417f76ddd6267eaa63a143648b64a2058c323
      https://github.com/wesnoth/wesnoth/commit/201417f76ddd6267eaa63a143648b64a2058c323
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/dialogs/end_credits.cpp
    M src/gui/dialogs/end_credits.hpp

  Log Message:
  -----------
  GUI2/End Credits: use DRAW event hook to scroll text instead of a timer

There's no visual difference between these methods since any of the scroll position changes wouldn't
take effect until the next draw anyway

  Commit: 4f159e2fd0cb7f05ce4aed4e570bbaa52e3e2beb
      https://github.com/wesnoth/wesnoth/commit/4f159e2fd0cb7f05ce4aed4e570bbaa52e3e2beb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: cleaned up set/get_active_sorting_option functions

* Cleaner implementation of get_active_sorting_option.
* Added some comments.

  Commit: 8b9a2f550e5778bfc02db7d0371a14d173934cdd
      https://github.com/wesnoth/wesnoth/commit/8b9a2f550e5778bfc02db7d0371a14d173934cdd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/listbox.hpp

  Log Message:
  -----------
  GUI2/Listbox: use an enum for update_visible_area_on_key_event's argument

  Commit: 17969718a7c0273f5cf7e75974a1035b58dbaca4
      https://github.com/wesnoth/wesnoth/commit/17969718a7c0273f5cf7e75974a1035b58dbaca4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  GUI2/Listbox: pass list_item_clicked directly to generator w/o intermediary helper

  Commit: eff2fc60e6b3c419fc44e80bc6000a1cd80be8df
      https://github.com/wesnoth/wesnoth/commit/eff2fc60e6b3c419fc44e80bc6000a1cd80be8df
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/gui/widgets/grid.hpp

  Log Message:
  -----------
  GUI2/Grid: explicitly delete copy and move ctors

The base class (widget) copy ctor and assignment operator are deleted, but this is to try to fix
some test build errors with GCC.

  Commit: cd68243e641a18d256840962f7993c373565ef24
      https://github.com/wesnoth/wesnoth/commit/cd68243e641a18d256840962f7993c373565ef24
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-08-26 (Sat, 26 Aug 2017)

  Changed paths:
    M src/tests/gui/iterator.cpp
    M src/tests/gui/visitor.cpp

  Log Message:
  -----------
  Attempt to fix build of unit tests on GCC 4.8

The tests were building just fine on Clang and GCC 7, but not on GCC 4.8
that Travis CI uses. That points towards a compiler bug. As a workaround,
simply initialize the widgets in a more straightforward way.

Compare: https://github.com/wesnoth/wesnoth/compare/d0a8f0a85884...cd68243e641a