[Commits] [wesnoth/wesnoth] 15084e: Preprocessor: refactor streambuf management of pre...

GitHub noreply at github.com
Tue Aug 29 03:21:47 UTC 2017


  Branch: refs/heads/preprocessor_cleanup
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 15084efb620dc323af03c39adbc06656bda14815
      https://github.com/wesnoth/wesnoth/commit/15084efb620dc323af03c39adbc06656bda14815
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: refactor streambuf management of preprocessor objects

Instead of using this complex system where new processor objects registered themselves as the
current preprocessor object in the base class ctor (this led to freestanding `new` statements
that looked like memory leaks), we now use a deque of unique_ptrs in the streambuf class. This
makes the code a lot clearer since all the memory management is is one place.


  Commit: 1cedead80fc853327aa0fcbf8fe716ecbfc40c4d
      https://github.com/wesnoth/wesnoth/commit/1cedead80fc853327aa0fcbf8fe716ecbfc40c4d
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: explicitly specify streambuf in the std namespace for clarity


Compare: https://github.com/wesnoth/wesnoth/compare/34df48195a42...1cedead80fc8


More information about the Commits mailing list