[Commits] [wesnoth/wesnoth] f2647c: Preprocessor: reformat this absolute mess of a fil...

GitHub noreply at github.com
Tue Aug 29 03:43:40 UTC 2017


  Branch: refs/heads/preprocessor_cleanup
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f2647c4bec4e0609808cec84e5b595231c7c9d1f
      https://github.com/wesnoth/wesnoth/commit/f2647c4bec4e0609808cec84e5b595231c7c9d1f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp
    M src/serialization/preprocessor.hpp

  Log Message:
  -----------
  Preprocessor: reformat this absolute mess of a file


  Commit: 13eff8cb39adadeca3adfe1a3cb9324489075521
      https://github.com/wesnoth/wesnoth/commit/13eff8cb39adadeca3adfe1a3cb9324489075521
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: used emplace_back in one place


  Commit: 213d785edeb2be8f91bb166a2e9f1ac57323aa43
      https://github.com/wesnoth/wesnoth/commit/213d785edeb2be8f91bb166a2e9f1ac57323aa43
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: refactor streambuf management of preprocessor objects

Instead of using this complex system where new processor objects registered themselves as the
current preprocessor object in the base class ctor (this led to freestanding `new` statements
that looked like memory leaks), we now use a deque of unique_ptrs in the streambuf class. This
makes the code a lot clearer since all the memory management is is one place.


  Commit: 050fe4cf0289ddae889cc451e0c725d6e4373528
      https://github.com/wesnoth/wesnoth/commit/050fe4cf0289ddae889cc451e0c725d6e4373528
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: explicitly specify streambuf in the std namespace for clarity


Compare: https://github.com/wesnoth/wesnoth/compare/1cedead80fc8...050fe4cf0289


More information about the Commits mailing list