[Commits] [wesnoth/wesnoth] 1a5e2c: Preprocessor: reformat this absolute mess of a fil...

GitHub noreply at github.com
Tue Aug 29 12:11:12 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 1a5e2ccfb7c1aa783223885929a80febc799d224
      https://github.com/wesnoth/wesnoth/commit/1a5e2ccfb7c1aa783223885929a80febc799d224
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp
    M src/serialization/preprocessor.hpp

  Log Message:
  -----------
  Preprocessor: reformat this absolute mess of a file


  Commit: dbbc92bca917705ca5de02eb3e1844165386eea3
      https://github.com/wesnoth/wesnoth/commit/dbbc92bca917705ca5de02eb3e1844165386eea3
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: used emplace_back in one place


  Commit: 613f1d9e7f8f08da98f50aea7beaba5524868cc7
      https://github.com/wesnoth/wesnoth/commit/613f1d9e7f8f08da98f50aea7beaba5524868cc7
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: refactor streambuf management of preprocessor objects

Instead of using this complex system where new processor objects registered themselves as the
current preprocessor object in the base class ctor (this led to freestanding `new` statements
that looked like memory leaks), we now use a deque of unique_ptrs in the streambuf class. This
makes the code a lot clearer since all the memory management is is one place.


  Commit: 9d89083ea570e01334feeecdc2815d99dfa51524
      https://github.com/wesnoth/wesnoth/commit/9d89083ea570e01334feeecdc2815d99dfa51524
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: explicitly specify streambuf in the std namespace for clarity


  Commit: 62d42738f3c607fbbdae410de9a0d79572abe119
      https://github.com/wesnoth/wesnoth/commit/62d42738f3c607fbbdae410de9a0d79572abe119
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M src/serialization/preprocessor.cpp

  Log Message:
  -----------
  Preprocessor: moved output separator character to a static constant

Also changed the character to hex escape form.


Compare: https://github.com/wesnoth/wesnoth/compare/468c6e0f4947...62d42738f3c6


More information about the Commits mailing list