[Commits] [wesnoth/wesnoth] b889fb: MP: fixed some user list issues

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b889fb86b477edd1c40f36ad605b890a8899b994
      https://github.com/wesnoth/wesnoth/commit/b889fb86b477edd1c40f36ad605b890a8899b994
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/game_initialization/connect_engine.cpp
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/multiplayer/mp_join_game.cpp

  Log Message:
  -----------
  MP: fixed some user list issues

* Fixed observers not being properly removed from the connected users list if they disconnected.
  This fixes #2287. I'm not exactly sure how this was handled before, but I changed the code in
  connect_engine to handle the observer_quit signal even if the observer had not been assigned a
  side (which it checked for before).
* Fixed an issue where a user would still be marked as connected if they canceled their Faction
  selection.