[Commits] [wesnoth/wesnoth] 594878: Improved console output on IPF fail

GitHub noreply at github.com
Tue Jul 4 22:43:53 UTC 2017


  Branch: refs/heads/accelerated_rendering
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5948783f65b78055b4ebd1d5812fa554a0280234
      https://github.com/wesnoth/wesnoth/commit/5948783f65b78055b4ebd1d5812fa554a0280234
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-06-28 (Wed, 28 Jun 2017)

  Changed paths:
    M src/image.cpp

  Log Message:
  -----------
  Improved console output on IPF fail

Yes, I know the duplicate code should be consolidated.


  Commit: 80da7f82f86010c43e3c5ab39be4d103cd3b7b19
      https://github.com/wesnoth/wesnoth/commit/80da7f82f86010c43e3c5ab39be4d103cd3b7b19
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-06-29 (Thu, 29 Jun 2017)

  Changed paths:
    M src/display.cpp
    M src/events.cpp
    M src/events.hpp
    M src/gui/core/event/handler.cpp
    M src/show_dialog.cpp
    M src/video.cpp
    M src/video.hpp
    M src/widgets/widget.cpp

  Log Message:
  -----------
  Refactor and cleanup of the drawing dispatch system

Previously, drawing was handled with custom DRAW and DRAW_ALL events which individual event handlers
managed. DRAW was used for only-as-needed draws, and DRAW_ALL for drawing everything. As we've switched
to accelerated rendering, we've switched to the latter model all the time; everything is always drawn.

Both DRAW and DRAW_ALL events aren't needed anymore and have been removed. Instead, we simply call each
handler's draw() function directly from events::pump. The two main cases that handled draw events - the
display class and GUI2 - just forwarded the event handler calls to their respective draw() functions anyway.

Awhile back to unconditionally send draw events to the event queue constantly every 20 ms. However, to prevent
draw calls from becoming backed up, the queue already had code to remove all but 1 draw event from the queue
anyway, so the actual rate of drawing was still reliant on the rate at which events::pump was called. Therefor
this commit should result in no change at the rate the screen is drawn.


  Commit: 5c5cc4fc16c9b3b50526c4aa96b704c9c27f1df4
      https://github.com/wesnoth/wesnoth/commit/5c5cc4fc16c9b3b50526c4aa96b704c9c27f1df4
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-06-30 (Fri, 30 Jun 2017)

  Changed paths:
    M projectfiles/CodeBlocks/wesnoth.cbp
    M source_lists/libwesnoth
    M src/arrow.cpp
    M src/arrow.hpp
    M src/display.cpp
    M src/display.hpp
    R src/drawing_buffer.cpp
    R src/drawing_buffer.hpp
    A src/drawing_queue.cpp
    A src/drawing_queue.hpp
    M src/editor/editor_display.cpp
    M src/game_display.cpp
    M src/units/animation.cpp
    M src/units/drawer.cpp
    M src/units/frame.cpp
    M src/units/frame.hpp
    M src/whiteboard/attack.cpp
    M src/whiteboard/manager.cpp
    M src/whiteboard/move.cpp
    M src/whiteboard/recall.cpp
    M src/whiteboard/recruit.cpp
    M src/whiteboard/suppose_dead.cpp

  Log Message:
  -----------
  Renamed drawing_buffer to drawing_queue

Also renamed drawing_queue::drawing_layer to just 'layer'.


Compare: https://github.com/wesnoth/wesnoth/compare/d5058ca3155b...5c5cc4fc16c9


More information about the Commits mailing list