[Commits] [wesnoth/wesnoth] 287d27: MP Join Game: fixed player list being incorrect (...

GitHub noreply at github.com
Mon Jul 31 01:23:55 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 287d27c37f2671b8b3e8e99f2b8925c66116beff
      https://github.com/wesnoth/wesnoth/commit/287d27c37f2671b8b3e8e99f2b8925c66116beff
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-07-31 (Mon, 31 Jul 2017)

  Changed paths:
    M src/gui/dialogs/multiplayer/mp_join_game.cpp
    M src/gui/dialogs/multiplayer/mp_join_game.hpp

  Log Message:
  -----------
  MP Join Game:  fixed player list being incorrect (fixes #1867 and probably #1598)

Basically switched this dialog to take userlist data from the server instead of the scenario config,
since the former caused various issues as listed in #1867.

I've also removed the manual call to update_player_list in pre_show since it's not really necessary
(and I don't have any list data to pass there anyway) since the network handler will call it once it
receives data.

A similar change isn't needed in MP Staging since the connect engine handles all the user list stuff.





More information about the Commits mailing list