[Commits] [wesnoth/wesnoth] 09c772: Fixup 3a301db7d46f

GitHub noreply at github.com
Fri Jun 2 14:09:10 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 09c77256fa13f32a425893df22045ed164a2a717
      https://github.com/wesnoth/wesnoth/commit/09c77256fa13f32a425893df22045ed164a2a717
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-06-03 (Sat, 03 Jun 2017)

  Changed paths:
    M src/video.cpp
    M src/video.hpp

  Log Message:
  -----------
  Fixup 3a301db7d46f

A pair of ints mean non-whole scale factors won't be properly considered.


  Commit: e188379cd2b3055d7c344b4316953a3d1e41b17f
      https://github.com/wesnoth/wesnoth/commit/e188379cd2b3055d7c344b4316953a3d1e41b17f
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-06-03 (Sat, 03 Jun 2017)

  Changed paths:
    M src/video.cpp

  Log Message:
  -----------
  Fixup ed9c4dff3567

The current resolution values are the effective screen resolution, not the physical ones. So, we want
to exclude resolutions greater than the effective res * the DPI scale factor (ie, the physical resolution),
not the res option * the DPI scale factor. That appears to be because the list of res options is of physical
resolutions so this properly excludes options that wouldn't be able to fit on the screen once scaled.


Compare: https://github.com/wesnoth/wesnoth/compare/ed9c4dff3567...e188379cd2b3


More information about the Commits mailing list