[Commits] [wesnoth/wesnoth] 4c0f4c: Attempted fix for GUI2 event firing test failures

GitHub noreply at github.com
Wed Jun 7 03:40:49 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4c0f4c31546719c0a5fefa6973e32f0494a62f00
      https://github.com/wesnoth/wesnoth/commit/4c0f4c31546719c0a5fefa6973e32f0494a62f00
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/gui/core/event/dispatcher_private.hpp
    M src/tests/gui/fire_event.cpp

  Log Message:
  -----------
  Attempted fix for GUI2 event firing test failures

Commit 315f8496b61db8347b694e2efadfe6ff9ccc7702 broke the test in two ways. First, I intentionally
changed pre and post events to be passed to the target widget as well, not
only its ancestors. The test verified that the events were *not* passed to
the target widget. Fixed by adjusting the test to verify that the target
widget now does receive the event.

Second, I unintentionally stopped the event dispatcher from receiving pre
and post events. Fixed.


  Commit: bb9ee94e4b8008f9988ea78ebf18ac974966c406
      https://github.com/wesnoth/wesnoth/commit/bb9ee94e4b8008f9988ea78ebf18ac974966c406
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M changelog
    M players_changelog

  Log Message:
  -----------
  Adjust changelog for commit 315f8496b61db8347b694e2efadfe6ff9ccc7702

I forgot to do it initially.


Compare: https://github.com/wesnoth/wesnoth/compare/315f8496b61d...bb9ee94e4b80


More information about the Commits mailing list