[Commits] [wesnoth/wesnoth] 5ba35e: test: Use a better error message when code.lua doe...

Mon Jun 12 07:38:34 UTC 2017

  Branch: refs/heads/accelerated_rendering
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5ba35e42b126a5271d9ac814aebdcf9c65e5fe35
      https://github.com/wesnoth/wesnoth/commit/5ba35e42b126a5271d9ac814aebdcf9c65e5fe35
  Author: Luther <lutheroto at gmail.com>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M data/core/about.cfg
    M data/scenario-test.cfg

  Log Message:
  -----------
  test: Use a better error message when code.lua doesn't exist (#1722)

  Commit: 315f8496b61db8347b694e2efadfe6ff9ccc7702
      https://github.com/wesnoth/wesnoth/commit/315f8496b61db8347b694e2efadfe6ff9ccc7702
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-06 (Tue, 06 Jun 2017)

  Changed paths:
    M src/gui/core/event/dispatcher_private.hpp
    M src/gui/widgets/scrollbar_container.cpp

  Log Message:
  -----------
  Allow widget::find_at() to return a scrollbar container

If the pointer wasn't on top of any widget within a scrollbar container,
when GUI2 queried the widget on which a UI event occurred, the answer was
"no widget" and the whole event was discarded.

That was problematic if the player was trying to scroll. It is desired that
scrolling is possible even if the pointer isn't on a widget (as long as
it's somewhere within the scrollbar container).

Now the query will return "scrollbar container" and dispatch the event to
it. That allows the player to scroll anywhere within a scrollbar container.

Also, now the GUI2 event chain includes the target widget itself, not only
its ancestors.

Fixes #1632.

  Commit: 4c0f4c31546719c0a5fefa6973e32f0494a62f00
      https://github.com/wesnoth/wesnoth/commit/4c0f4c31546719c0a5fefa6973e32f0494a62f00
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/gui/core/event/dispatcher_private.hpp
    M src/tests/gui/fire_event.cpp

  Log Message:
  -----------
  Attempted fix for GUI2 event firing test failures

Commit 315f8496b61db8347b694e2efadfe6ff9ccc7702 broke the test in two ways. First, I intentionally
changed pre and post events to be passed to the target widget as well, not
only its ancestors. The test verified that the events were *not* passed to
the target widget. Fixed by adjusting the test to verify that the target
widget now does receive the event.

Second, I unintentionally stopped the event dispatcher from receiving pre
and post events. Fixed.

  Commit: bb9ee94e4b8008f9988ea78ebf18ac974966c406
      https://github.com/wesnoth/wesnoth/commit/bb9ee94e4b8008f9988ea78ebf18ac974966c406
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M changelog
    M players_changelog

  Log Message:
  -----------
  Adjust changelog for commit 315f8496b61db8347b694e2efadfe6ff9ccc7702

I forgot to do it initially.

  Commit: 9628109666e5c91633b8d70682063a975a8679ff
      https://github.com/wesnoth/wesnoth/commit/9628109666e5c91633b8d70682063a975a8679ff
  Author: Pranav Deshpande <universecoder at users.noreply.github.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M src/gui/dialogs/unit_recall.cpp
    M src/gui/dialogs/unit_recall.hpp

  Log Message:
  -----------
  Issue #1738: Changed unit_recall dialogue box  (#1760)

* Changed unit_recall dialogue box to sort by 1. level, 2. experience_to_advance

* Sorted recall_list_ by level, experience_to_advance and max_hitpoints

* Sorted recall_list by 1. Level, 2. Experience to advance

* Sorted recall_list_ by 1. Level, 2. Experience to advancement

* Sorted recall_list by 1. Level, 2. Experience to advance

  Commit: 365a8fcc913cac94a64d206d0144b28e206669c6
      https://github.com/wesnoth/wesnoth/commit/365a8fcc913cac94a64d206d0144b28e206669c6
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M data/core/about.cfg

  Log Message:
  -----------
  Add @universecoder to credits

  Commit: 5a6203bc33f632068d8ea028330bbc03964a07d9
      https://github.com/wesnoth/wesnoth/commit/5a6203bc33f632068d8ea028330bbc03964a07d9
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M changelog
    M players_changelog

  Log Message:
  -----------
  Changelog entry for the implementation of #1738

  Commit: 5d5982c8a76267b8b0a351cad5871b973487af0f
      https://github.com/wesnoth/wesnoth/commit/5d5982c8a76267b8b0a351cad5871b973487af0f
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-06-08 (Thu, 08 Jun 2017)

  Changed paths:
    M src/gui/dialogs/unit_recall.cpp

  Log Message:
  -----------
  don't assume < 1000 xp in the recall dialog.

im not sure whether this will sorty by desccending or by ascending order by default, so it maybe needs to be swapped later.

  Commit: b26cb7aa284b5a5d5b51697aba58836f809b049c
      https://github.com/wesnoth/wesnoth/commit/b26cb7aa284b5a5d5b51697aba58836f809b049c
  Author: sigurdfdragon <jjwcoat at gmail.com>
  Date:   2017-06-07 (Wed, 07 Jun 2017)

  Changed paths:
    M data/campaigns/Secrets_of_the_Ancients/scenarios/01_Slipping_Away.cfg

  Log Message:
  -----------
  SotA S1: Simplify sentence

>From discussion of e1f98a8782e2ac07952cd0f65d78b68c1da52570

  Commit: 58e8f8284b1e17613e278d3dacba25a7aebfc1fb
      https://github.com/wesnoth/wesnoth/commit/58e8f8284b1e17613e278d3dacba25a7aebfc1fb
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-08 (Thu, 08 Jun 2017)

  Changed paths:
    M src/gui/dialogs/unit_recall.cpp

  Log Message:
  -----------
  Stop pre-sorting the unit recall list

Requested by @gfgtdf in #1760.

  Commit: 93be1487fac79406c30c71e5b2a79e43ca722770
      https://github.com/wesnoth/wesnoth/commit/93be1487fac79406c30c71e5b2a79e43ca722770
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-08 (Thu, 08 Jun 2017)

  Changed paths:
    M src/attack_prediction.cpp

  Log Message:
  -----------
  Teach damage prediction that level-up heals poison and slow

Closes #1764.

  Commit: 2aefb78ab7595d5f6d5939f22a3354eb2e72c02b
      https://github.com/wesnoth/wesnoth/commit/2aefb78ab7595d5f6d5939f22a3354eb2e72c02b
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-09 (Fri, 09 Jun 2017)

  Changed paths:
    M src/attack_prediction.cpp

  Log Message:
  -----------
  Fix build with -Werror=unused-variable

  Commit: b0f15a08c4b17eed3bc26294d3f1c981d6ebe24c
      https://github.com/wesnoth/wesnoth/commit/b0f15a08c4b17eed3bc26294d3f1c981d6ebe24c
  Author: Elias Pschernig <elias at users.sourceforge.net>
  Date:   2017-06-09 (Fri, 09 Jun 2017)

  Changed paths:
    M data/tools/wmlunits

  Log Message:
  -----------
  units.wesnoth.org update to understand new [difficulty] tag

  Commit: df6a775ee8320841985e7427d34ac3f23290b651
      https://github.com/wesnoth/wesnoth/commit/df6a775ee8320841985e7427d34ac3f23290b651
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2017-06-10 (Sat, 10 Jun 2017)

  Changed paths:
    M src/serialization/string_view.hpp

  Log Message:
  -----------
  Compilation - at least in MSVC - of custom string_view.hpp was not properly recognising the installed boost version, causing compiler warnings of redefinition of BOOST_CXX14_CONSTEXPR.

  Commit: 13b5e8421a3d5389b032502f8a92d471c5ae8257
      https://github.com/wesnoth/wesnoth/commit/13b5e8421a3d5389b032502f8a92d471c5ae8257
  Author: ln-zookeeper <lari.nieminen at iki.fi>
  Date:   2017-06-10 (Sat, 10 Jun 2017)

  Changed paths:
    M data/core/units/monsters/Tentacle.cfg

  Log Message:
  -----------
  Rewrote Tentacle of the Deep base image path to include a fallback

For example the units.wesnoth.org pages cannot process IPFs, and will use the base image file verbatim, so this makes sure that it at least shows the tentacle base frame instead of blank-hex.png.

  Commit: 3b0f14983922b2a87355cd97d50e16bc98261841
      https://github.com/wesnoth/wesnoth/commit/3b0f14983922b2a87355cd97d50e16bc98261841
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-10 (Sat, 10 Jun 2017)

  Changed paths:
    M src/gui/widgets/listbox.cpp

  Log Message:
  -----------
  Fix crash on sorting an empty listbox with select_first=true

  Commit: 45b749bce615081501cee93016d6e81c5ed51e05
      https://github.com/wesnoth/wesnoth/commit/45b749bce615081501cee93016d6e81c5ed51e05
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-10 (Sat, 10 Jun 2017)

  Changed paths:
    M src/gui/widgets/addon_list.cpp
    M src/gui/widgets/addon_list.hpp

  Log Message:
  -----------
  Sort the add-on list by name by default

Requested by @shikadilord.

  Commit: 7537272bb2fbff9f08a49b7cd1883200d613ff9f
      https://github.com/wesnoth/wesnoth/commit/7537272bb2fbff9f08a49b7cd1883200d613ff9f
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-06-10 (Sat, 10 Jun 2017)

  Changed paths:
    M src/gui/widgets/addon_list.cpp

  Log Message:
  -----------
  Fix crash in GUI2 unit tests

  Commit: 8b0c9af52dc165ba5ab3466c68bdd9d0940ae658
      https://github.com/wesnoth/wesnoth/commit/8b0c9af52dc165ba5ab3466c68bdd9d0940ae658
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-06-10 (Sat, 10 Jun 2017)

  Changed paths:
    M src/savegame.cpp

  Log Message:
  -----------
  fix crash when loading a replay stored on the server #1762

  Commit: 5d43078ba43c3120daddf1f07a628cffdc195b5b
      https://github.com/wesnoth/wesnoth/commit/5d43078ba43c3120daddf1f07a628cffdc195b5b
  Author: Celtic Minstrel <CelticMinstrel at users.noreply.github.com>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M data/gui/widget/text_box_default.cfg
    M src/gui/core/event/dispatcher.cpp
    M src/gui/core/event/dispatcher.hpp
    M src/gui/core/event/dispatcher_private.hpp
    M src/gui/core/event/distributor.cpp
    M src/gui/core/event/distributor.hpp
    M src/gui/core/event/handler.cpp
    M src/gui/core/event/handler.hpp
    M src/gui/widgets/text_box.cpp
    M src/gui/widgets/text_box.hpp
    M src/gui/widgets/text_box_base.cpp
    M src/gui/widgets/text_box_base.hpp
    M src/gui/widgets/window.cpp
    M src/key.cpp

  Log Message:
  -----------
  [WIP] Implement IME support for GUI2 textboxes (#1758)

Implement IME support for GUI2 textboxes

  Commit: c274e6569d01b988d58a8215075b3f5c536cbc47
      https://github.com/wesnoth/wesnoth/commit/c274e6569d01b988d58a8215075b3f5c536cbc47
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M src/hotkey/command_executor.cpp

  Log Message:
  -----------
  Fix double-showing of Lua console (addresses #1601 and #1736)

  Commit: 5d9cd6d4851de73e1691ea563f86ace3693a0595
      https://github.com/wesnoth/wesnoth/commit/5d9cd6d4851de73e1691ea563f86ace3693a0595
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M src/gui/core/event/handler.cpp

  Log Message:
  -----------
  Fix some hotkeys not working at titlescreen (fixes #1737)

  Commit: 55e93059d246902f5db353a8d4346926f295d94c
      https://github.com/wesnoth/wesnoth/commit/55e93059d246902f5db353a8d4346926f295d94c
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M src/hotkey/hotkey_handler.cpp

  Log Message:
  -----------
  Process WML menuitems only on key release (addresses #1711)

  Commit: ee111dbfc219639b069de76e4bf7343d46798dce
      https://github.com/wesnoth/wesnoth/commit/ee111dbfc219639b069de76e4bf7343d46798dce
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M src/generators/lua_map_generator.hpp

  Log Message:
  -----------
  Fix user_config key for Lua map generators

  Commit: ea47206fc9c7cc8d329597e83f127a7a1f20036a
      https://github.com/wesnoth/wesnoth/commit/ea47206fc9c7cc8d329597e83f127a7a1f20036a
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M src/gui/dialogs/story_viewer.hpp

  Log Message:
  -----------
  Fix [story] not showing if all parts are conditional

  Commit: 728f2972086fd8ea53f5abdd9f23461ac708d7b4
      https://github.com/wesnoth/wesnoth/commit/728f2972086fd8ea53f5abdd9f23461ac708d7b4
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M src/units/unit.cpp

  Log Message:
  -----------
  Fix missing XP in trait descriptions (fixes #1776)

  Commit: 38b9b6dd588ffb188c04950ba182207a093fca53
      https://github.com/wesnoth/wesnoth/commit/38b9b6dd588ffb188c04950ba182207a093fca53
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-06-11 (Sun, 11 Jun 2017)

  Changed paths:
    M RELEASE_NOTES
    M changelog

  Log Message:
  -----------
  Update changelog and release notes

  Commit: 2de925e4e62b5837f4b2d3c5b13b51e0aca1ff59
      https://github.com/wesnoth/wesnoth/commit/2de925e4e62b5837f4b2d3c5b13b51e0aca1ff59
  Author: Wedge009 <wedge009 at wedge009.net>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M changelog
    M src/key.cpp

  Log Message:
  -----------
  Resolve hot-keys involving space not working (#1737 and #1769)

Just added space to list of 'uncomposable' keys.

  Commit: ae75919cad7829468d1626fe17d6c85ee7b4535c
      https://github.com/wesnoth/wesnoth/commit/ae75919cad7829468d1626fe17d6c85ee7b4535c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-06-12 (Mon, 12 Jun 2017)

  Changed paths:
    M RELEASE_NOTES
    M changelog
    M data/campaigns/Secrets_of_the_Ancients/scenarios/01_Slipping_Away.cfg
    M data/core/about.cfg
    M data/core/units/monsters/Tentacle.cfg
    M data/gui/widget/text_box_default.cfg
    M data/scenario-test.cfg
    M data/tools/wmlunits
    M players_changelog
    M src/attack_prediction.cpp
    M src/generators/lua_map_generator.hpp
    M src/gui/core/event/dispatcher.cpp
    M src/gui/core/event/dispatcher.hpp
    M src/gui/core/event/dispatcher_private.hpp
    M src/gui/core/event/distributor.cpp
    M src/gui/core/event/distributor.hpp
    M src/gui/core/event/handler.cpp
    M src/gui/core/event/handler.hpp
    M src/gui/dialogs/story_viewer.hpp
    M src/gui/dialogs/unit_recall.cpp
    M src/gui/dialogs/unit_recall.hpp
    M src/gui/widgets/addon_list.cpp
    M src/gui/widgets/addon_list.hpp
    M src/gui/widgets/listbox.cpp
    M src/gui/widgets/scrollbar_container.cpp
    M src/gui/widgets/text_box.cpp
    M src/gui/widgets/text_box.hpp
    M src/gui/widgets/text_box_base.cpp
    M src/gui/widgets/text_box_base.hpp
    M src/gui/widgets/window.cpp
    M src/hotkey/command_executor.cpp
    M src/hotkey/hotkey_handler.cpp
    M src/key.cpp
    M src/savegame.cpp
    M src/serialization/string_view.hpp
    M src/tests/gui/fire_event.cpp
    M src/units/unit.cpp

  Log Message:
  -----------
  Merge branch 'master' into accelerated_rendering

Compare: https://github.com/wesnoth/wesnoth/compare/b7000a508560...ae75919cad78