[Commits] [wesnoth/wesnoth] b1ea09: Small fixup to 42f087abb
GitHub
noreply at github.com
Thu Mar 2 23:52:54 UTC 2017
Branch: refs/heads/master
Home: https://github.com/wesnoth/wesnoth
Commit: b1ea099da4d6731f61a70578605b69bed896a04e
https://github.com/wesnoth/wesnoth/commit/b1ea099da4d6731f61a70578605b69bed896a04e
Author: Charles Dang <exodia339 at gmail.com>
Date: 2017-03-03 (Fri, 03 Mar 2017)
Changed paths:
M src/units/frame.cpp
Log Message:
-----------
Small fixup to 42f087abb
The old `tristate_to_bool` function returned the second argument if the value was `t_unset`. boost::tribool can be converted to bool,
but the intermediate state returns false. In this case, the only usecase of `tristate_to_bool` had true as a second argument, and I had
forgotten to explicitly check for the intermediate state when I switched to boost::tribool.
It might be useful to re-add the `tristate_to_bool` function again if conversions to bool become more common, but for now this simple
check works.
More information about the Commits
mailing list