[Commits] [wesnoth/wesnoth] 532e4c: use the original action codepath when redoding

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 532e4c7de6ec647fe668c4a36ee8d64cf1c22219
      https://github.com/wesnoth/wesnoth/commit/532e4c7de6ec647fe668c4a36ee8d64cf1c22219
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-02-24 (Fri, 24 Feb 2017)

  Changed paths:
    M src/actions/undo.cpp
    M src/actions/undo.hpp
    M src/actions/undo_action.cpp
    M src/actions/undo_action.hpp
    M src/actions/undo_dismiss_action.cpp
    M src/actions/undo_dismiss_action.hpp
    M src/actions/undo_move_action.cpp
    M src/actions/undo_move_action.hpp
    M src/actions/undo_recall_action.cpp
    M src/actions/undo_recall_action.hpp
    M src/actions/undo_recruit_action.cpp
    M src/actions/undo_recruit_action.hpp

  Log Message:
  -----------
  use the original action codepath when redoding

this removes all those redo() functions for each undo actions. Instead,
the game now just uses the replaywml that was taken from the replay when
undoing the action to redo it by calling the usual synced:context::run
function, just like when that action was executed for the first time.

The main advantage is that [on_redo] is no longer nesasary since the
game will ow just fire the action related wml events again when redoing
the actions.

See also http://gna.org/bugs/?25472


  Commit: 41c4ecbe7d1f48a83b4e6c998d1dc5dbab41a2de
      https://github.com/wesnoth/wesnoth/commit/41c4ecbe7d1f48a83b4e6c998d1dc5dbab41a2de
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-02-24 (Fri, 24 Feb 2017)

  Changed paths:
    M src/game_events/action_wml.cpp
    M src/synced_context.cpp
    M src/synced_context.hpp

  Log Message:
  -----------
  remove some now unused code


  Commit: d23eb4e3567b2a6c08678ceabcde302cfb572cf5
      https://github.com/wesnoth/wesnoth/commit/d23eb4e3567b2a6c08678ceabcde302cfb572cf5
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-02-24 (Fri, 24 Feb 2017)

  Changed paths:
    M src/game_events/action_wml.cpp

  Log Message:
  -----------
  fix unused parameter


  Commit: 33c2e6aa67c9377f170f9302204a8de10c200564
      https://github.com/wesnoth/wesnoth/commit/33c2e6aa67c9377f170f9302204a8de10c200564
  Author: gfgtdf <daniel.gfgtdf at gmail.com>
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
    M src/actions/undo.cpp
    M src/actions/undo.hpp
    M src/actions/undo_action.cpp
    M src/actions/undo_action.hpp
    M src/actions/undo_dismiss_action.cpp
    M src/actions/undo_dismiss_action.hpp
    M src/actions/undo_move_action.cpp
    M src/actions/undo_move_action.hpp
    M src/actions/undo_recall_action.cpp
    M src/actions/undo_recall_action.hpp
    M src/actions/undo_recruit_action.cpp
    M src/actions/undo_recruit_action.hpp
    M src/game_events/action_wml.cpp
    M src/synced_context.cpp
    M src/synced_context.hpp

  Log Message:
  -----------
  Merge pull request #936 from gfgtdf/no_on_redo

use the original action codepath when redoing


Compare: https://github.com/wesnoth/wesnoth/compare/81504c8da397...33c2e6aa67c9