[Commits] [wesnoth/wesnoth] f815c2: Pass strings by constref when possible

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f815c2272ad54831a014ea421139b5b18b85a2a3
      https://github.com/wesnoth/wesnoth/commit/f815c2272ad54831a014ea421139b5b18b85a2a3
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/carryover.cpp
    M src/carryover.hpp
    M src/filesystem.hpp
    M src/filesystem_boost.cpp
    M src/font/error.hpp
    M src/game_launcher.hpp
    M src/generic_event.cpp
    M src/generic_event.hpp
    M src/gui/dialogs/gamestate_inspector.cpp
    M src/gui/dialogs/lua_interpreter.cpp
    M src/hotkey/hotkey_item.cpp
    M src/hotkey/hotkey_item.hpp
    M src/image_modifications.hpp
    M src/mp_ui_alerts.cpp
    M src/scripting/lua_unit_attacks.cpp
    M src/serialization/preprocessor.cpp
    M src/serialization/preprocessor.hpp
    M src/serialization/string_utils.cpp
    M src/serialization/string_utils.hpp
    M src/synced_user_choice.cpp
    M src/synced_user_choice.hpp
    M src/theme.cpp
    M src/theme.hpp
    M src/units/udisplay.cpp
    M src/units/udisplay.hpp

  Log Message:
  -----------
  Pass strings by constref when possible

These instances were found by cppcheck.
Thanks matthiaskrgr for running it.


  Commit: 12cf0fb45e68028e5524f44ac7f08d9dc9fe0dc6
      https://github.com/wesnoth/wesnoth/commit/12cf0fb45e68028e5524f44ac7f08d9dc9fe0dc6
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/display_chat_manager.cpp
    M src/game_preferences.cpp
    M src/help/help_impl.cpp
    M src/server/server.cpp

  Log Message:
  -----------
  Replace some uses of string::find with string::compare

These instances were found by cppcheck.
Thanks matthiaskrgr for running it.


  Commit: 6b251d445c4d3d4e8a889b32d3a1bc5d5bd80b6d
      https://github.com/wesnoth/wesnoth/commit/6b251d445c4d3d4e8a889b32d3a1bc5d5bd80b6d
  Author: Celtic Minstrel <celtic.minstrel.ca at some.place>
  Date:   2017-03-16 (Thu, 16 Mar 2017)

  Changed paths:
    M src/config.cpp
    M src/game_board.cpp
    M src/units/filter.hpp
    M src/utils/functional.hpp
    M src/xBRZ/xbrz.cpp

  Log Message:
  -----------
  Address a few other issues found by cppcheck

Thanks matthiaskrgr for running it.


Compare: https://github.com/wesnoth/wesnoth/compare/c04e4a4a39e6...6b251d445c4d