[Commits] [wesnoth/wesnoth] 5d74d3: Editor: fix button overlay disappearing when a GUI...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 5d74d3bc195226412b71460ee433dff92879320b
      https://github.com/wesnoth/wesnoth/commit/5d74d3bc195226412b71460ee433dff92879320b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-01 (Mon, 01 May 2017)

  Changed paths:
    M src/display.cpp

  Log Message:
  -----------
  Editor: fix button overlay disappearing when a GUI2 dialog was open

The problem was that the redraw observer, which handled setting the button states - including the overlays, which
aren't specified in the ThemeWML - was called *after* a draw happened, meaning the buttons were drawn without
overlays properly registered.

This moves the firing of redraw observes before the draw call. The only code that used the redraw ovserver functionality
was the editor, so this shouldn't break anything.