[Commits] [wesnoth/wesnoth] 4345c5: Team Info: default-initialize side value as 1 inst...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 4345c54e61af382e2473f003dcfd0b798b1e9944
      https://github.com/wesnoth/wesnoth/commit/4345c54e61af382e2473f003dcfd0b798b1e9944
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-01 (Mon, 01 May 2017)

  Changed paths:
    M src/team.cpp

  Log Message:
  -----------
  Team Info: default-initialize side value as 1 instead of 0

0 is a invalid value. This was causing sides in the editor to always have sides with said value set to 0,
which caused problems after 12f9215da24. This is not the entire fix, but it will fix the immediate crash
when adding a side in the editor.


  Commit: 208e1640e6c254001f1b43421610d1fa5ff74e1a
      https://github.com/wesnoth/wesnoth/commit/208e1640e6c254001f1b43421610d1fa5ff74e1a
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-01 (Mon, 01 May 2017)

  Changed paths:
    M src/editor/map/map_context.cpp
    M src/editor/map/map_context.hpp

  Log Message:
  -----------
  Editor: fixed added sides never having the proper side number

All sides were previously default-initialized with the default side number (1).


  Commit: 2877a20439cc328131684536c248c839bb0d7abe
      https://github.com/wesnoth/wesnoth/commit/2877a20439cc328131684536c248c839bb0d7abe
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-01 (Mon, 01 May 2017)

  Changed paths:
    M src/editor/map/context_manager.cpp

  Log Message:
  -----------
  Editor Edit Side: remove hack to properly set side variable in editor_team_info

As of 208e1640e, the side number is set properly, so this is no longer needed.


Compare: https://github.com/wesnoth/wesnoth/compare/5d74d3bc1952...2877a20439cc