[Commits] [wesnoth/wesnoth] 890177: GUI2: fixed disconnect_signal searching the wrong ...

GitHub noreply at github.com
Mon May 1 13:30:10 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 890177d170d1e18ff2b7f59ae39cfade518c6be2
      https://github.com/wesnoth/wesnoth/commit/890177d170d1e18ff2b7f59ae39cfade518c6be2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-01 (Mon, 01 May 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2: fixed disconnect_signal searching the wrong queue 2/3 of the time


  Commit: 81eb23c74e8ad86d0354a195e668c0c79546f4fd
      https://github.com/wesnoth/wesnoth/commit/81eb23c74e8ad86d0354a195e668c0c79546f4fd
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-02 (Tue, 02 May 2017)

  Changed paths:
    M src/gui/core/event/dispatcher.hpp

  Log Message:
  -----------
  GUI2: remove every matching signal from an event queue when disconnecting

I'm not exactly sure if this is a desired change. It does allow the use of std::list::remove_if to simplify
the code a bit, but if first-only removal should be kept I can change it.


Compare: https://github.com/wesnoth/wesnoth/compare/726db2dee34a...81eb23c74e8a


More information about the Commits mailing list