[Commits] [wesnoth/wesnoth] 657942: Removed an unnecessary wmi_container include

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 6579424f6e740e997ad26133d1c462afd102f416
      https://github.com/wesnoth/wesnoth/commit/6579424f6e740e997ad26133d1c462afd102f416
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/carryover.hpp

  Log Message:
  -----------
  Removed an unnecessary wmi_container include


  Commit: 933cb168f96df5f67796228aaab645847f8d5b37
      https://github.com/wesnoth/wesnoth/commit/933cb168f96df5f67796228aaab645847f8d5b37
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/game_events/wmi_container.cpp

  Log Message:
  -----------
  WMI Container: code formatting


  Commit: 9cf3a51480310bfdc952484aef7c9effd3b8f1ea
      https://github.com/wesnoth/wesnoth/commit/9cf3a51480310bfdc952484aef7c9effd3b8f1ea
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/game_events/wmi_container.cpp
    M src/game_events/wmi_container.hpp

  Log Message:
  -----------
  WMI Container: added getter for a single item


  Commit: e6fc4cb0b6f0455cea3fb208ccaa86744496d49c
      https://github.com/wesnoth/wesnoth/commit/e6fc4cb0b6f0455cea3fb208ccaa86744496d49c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/hotkey/hotkey_handler_sp.cpp

  Log Message:
  -----------
  Made use of wmi_container::get_item instead of an iterator


  Commit: 08cdfba96bce39508367f89036d287024f0255b1
      https://github.com/wesnoth/wesnoth/commit/08cdfba96bce39508367f89036d287024f0255b1
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/game_events/wmi_container.cpp
    M src/game_events/wmi_container.hpp

  Log Message:
  -----------
  WMI Container: removed iterator and container interface

This probably existed to allow simple range-for code in pre-C++11 days when we were using the
BOOST_FOREACH macro. IIRC that required an iterator. However, with C++11 and range-for, it's
much simple to simply specify the `.second` when necessary than having a whole convoluted interface
and iterator extension just to avoid having to type that.

This also changes the return type of 'erase' to bool. It also leaves the empty() and size() functions,
since those might be useful.


  Commit: 1ea8e0f05cce2024979cf1cb74e623ac5639074c
      https://github.com/wesnoth/wesnoth/commit/1ea8e0f05cce2024979cf1cb74e623ac5639074c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M projectfiles/CodeBlocks/wesnoth.cbp
    M projectfiles/VC12/wesnoth.vcxproj
    M projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj
    M source_lists/wesnoth
    M src/game_events/manager.hpp
    R src/game_events/wmi_container.cpp
    R src/game_events/wmi_container.hpp
    A src/game_events/wmi_manager.cpp
    A src/game_events/wmi_manager.hpp
    M src/game_state.cpp
    M src/game_state.hpp
    M src/hotkey/hotkey_handler.cpp
    M src/hotkey/hotkey_handler_sp.cpp

  Log Message:
  -----------
  Renamed wmi_container to wmi_manager

Since it's not a container anymore, it shouldn't be called such.


  Commit: db582c09eaa30c7505785b2c80d0faf4d7e1e44e
      https://github.com/wesnoth/wesnoth/commit/db582c09eaa30c7505785b2c80d0faf4d7e1e44e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M projectfiles/CodeBlocks/wesnoth.cbp
    R src/utils/iterator.hpp

  Log Message:
  -----------
  Removed iterator_extend util class

The WMI container was the last use of it, and there are similar equivalents in boost if we ever need
such a thing in the future.


  Commit: 7677e7a77d46abf47fe56c5fe77ecac40818a82e
      https://github.com/wesnoth/wesnoth/commit/7677e7a77d46abf47fe56c5fe77ecac40818a82e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/game_events/wmi_manager.hpp

  Log Message:
  -----------
  WMI Manager: formatting update for the header


  Commit: dd714a09993ae41ce63b36d9990963e36b512caf
      https://github.com/wesnoth/wesnoth/commit/dd714a09993ae41ce63b36d9990963e36b512caf
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-19 (Fri, 19 May 2017)

  Changed paths:
    M src/game_events/wmi_manager.cpp

  Log Message:
  -----------
  WMI Manager: some light refactoring to simplify a few things


Compare: https://github.com/wesnoth/wesnoth/compare/2b5d1b80d6b7...dd714a09993a