[Commits] [wesnoth/wesnoth] a221d4: Clean up display::clear_screen

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a221d40abf1fe0379fb069a3f7fc23a50af364eb
      https://github.com/wesnoth/wesnoth/commit/a221d40abf1fe0379fb069a3f7fc23a50af364eb
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-26 (Fri, 26 May 2017)

  Changed paths:
    M src/display.cpp

  Log Message:
  -----------
  Clean up display::clear_screen


  Commit: 4b95691660dbd32d2665a156f54d14b878a5881b
      https://github.com/wesnoth/wesnoth/commit/4b95691660dbd32d2665a156f54d14b878a5881b
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-26 (Fri, 26 May 2017)

  Changed paths:
    M src/display.cpp
    M src/widgets/textbox.cpp
    M src/widgets/textbox.hpp

  Log Message:
  -----------
  Use fill_rectangle over fill_rect when possible

The rectangle drawing primitives are most suitable for drawing to the full screen with global rects,
not specific surfaces. The rect issue *could* be solvable, but the bigger issue is if the surface needs
further processing the rectangle won't be present.


  Commit: 078a4f6a646ccba90e65f0e42f6be8ba2e831f85
      https://github.com/wesnoth/wesnoth/commit/078a4f6a646ccba90e65f0e42f6be8ba2e831f85
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-26 (Fri, 26 May 2017)

  Changed paths:
    M src/display.cpp
    M src/floating_label.cpp
    M src/minimap.cpp
    M src/sdl/rect.hpp
    M src/sdl/utils.cpp
    M src/units/drawer.cpp

  Log Message:
  -----------
  Renamed fill_rect fill_surface_rect to better distinguish it


  Commit: ffbaa84a4b72b97b1366bc377e65f53aefeabbd6
      https://github.com/wesnoth/wesnoth/commit/ffbaa84a4b72b97b1366bc377e65f53aefeabbd6
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-26 (Fri, 26 May 2017)

  Changed paths:
    M src/sdl/rect.cpp
    M src/sdl/rect.hpp

  Log Message:
  -----------
  Marked create_rect inline and updated its documentation


Compare: https://github.com/wesnoth/wesnoth/compare/4f48d09ac880...ffbaa84a4b72