[Commits] [wesnoth/wesnoth] 13fb9f: Register Widget: formatting cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 13fb9fb4f1d16ee4bbf2e14a6533ef148bc2d25c
      https://github.com/wesnoth/wesnoth/commit/13fb9fb4f1d16ee4bbf2e14a6533ef148bc2d25c
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-29 (Mon, 29 May 2017)

  Changed paths:
    M src/gui/core/register_widget.hpp

  Log Message:
  -----------
  Register Widget: formatting cleanup


  Commit: 4d00a81fe7bf2d992ebb0213ba30261ad7295ae9
      https://github.com/wesnoth/wesnoth/commit/4d00a81fe7bf2d992ebb0213ba30261ad7295ae9
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-05-29 (Mon, 29 May 2017)

  Changed paths:
    M src/gui/core/window_builder.cpp
    M src/gui/core/window_builder.hpp
    M src/gui/widgets/helper.cpp
    M src/gui/widgets/settings.cpp
    M src/gui/widgets/settings.hpp

  Log Message:
  -----------
  GUI2/Settings: bunch of cleanup and minor refactoring

Notable changes:
* get_window_builder now returns a const reference instead of an iterator.
* gui_definition and builder_window (not the one in window.cpp) now take a config reference directly
  and call read() from their ctors instead of requiring that be called manually.
* Added some more documentation.
* Made variable names more accurate.
* Removed some unused static variables
* Removed the unused non-class load_widget_definitions function (the gui_definition member of the same
  name remains.


Compare: https://github.com/wesnoth/wesnoth/compare/fbeb6c5b09d8...4d00a81fe7bf