[Commits] [wesnoth/wesnoth] 67a433: Preferences Dialog: fixed friends list row being a...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 67a43390f84cbe766d7623466bc8bd9116b1f82e
      https://github.com/wesnoth/wesnoth/commit/67a43390f84cbe766d7623466bc8bd9116b1f82e
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-03 (Fri, 03 Nov 2017)

  Changed paths:
    M src/chat_command_handler.cpp
    M src/gui/dialogs/preferences_dialog.cpp
    M src/preferences/game.cpp
    M src/preferences/game.hpp

  Log Message:
  -----------
  Preferences Dialog: fixed friends list row being added even if username was a duplicate

This fixes #2156.

preferences::add_acquaintance replaces the existing friend entry if the given username
has already been added to the acquaintance list, but the prefs dialog always added a
new row unconditionally. I've changed it to only add a new row if the username creates
a new entry, else replace the appropriate exiting row.