[Commits] [wesnoth/wesnoth] e41534: MP: wait at the loading screen until initial lobby...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: e41534d114437b26c735915f530df2cbc28e6c15
      https://github.com/wesnoth/wesnoth/commit/e41534d114437b26c735915f530df2cbc28e6c15
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M src/game_initialization/multiplayer.cpp
    M src/gui/dialogs/loading_screen.cpp
    M src/gui/dialogs/loading_screen.hpp
    M src/gui/dialogs/multiplayer/lobby.cpp

  Log Message:
  -----------
  MP: wait at the loading screen until initial lobby data is fetched

This does require some more usability improvements in the future, though. First off, this change was introduced
to get rid of that pause when the lobby is first opened before any contents appears. However, this change only
affects the initial connection, not any subsequent returns to the lobby.

Second, this also means the user doesn't have a way to quit to the titlescreen if the data fetching is taking an
especially long time anymore. It was suggested instead of this, we add some indicator to the lobby that data is
being fetched, but I don't know if that's really feasible with our toolkit. Still, we should add some way to exit
the loading screen if this is taking too long.

Lastly (and building on the above, though this is a more general issue), if at any point the server conks out and
doesn't send the lobby data, or a handshake, or anything, there's no way to exit the loading screen at that point.
Need to come up with a solution for that - either a timeout, or an exit button.