[Commits] [wesnoth/wesnoth] b5e33e: MP: removed on-connection handing of unused join_g...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: b5e33ec626895df86aec81a5186fa2a7f1794864
      https://github.com/wesnoth/wesnoth/commit/b5e33ec626895df86aec81a5186fa2a7f1794864
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  MP: removed on-connection handing of unused join_game signal

I can't find any code on the server side that would send this signal, so I'm assuming it must
be a relic of some removed feature. In any case, we don't support joining MP games by bypassing
the lobby.

Note the `if(!received_join_lobby)` check was removed since it could only apply to a case where
join_game was received, since there are only two loop-exit conditions.


  Commit: ef23e40d6b930d6a15fc6a1488c63eb15a595009
      https://github.com/wesnoth/wesnoth/commit/ef23e40d6b930d6a15fc6a1488c63eb15a595009
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-10 (Fri, 10 Nov 2017)

  Changed paths:
    M src/game_initialization/multiplayer.cpp

  Log Message:
  -----------
  MP: clean up e41534d1144 to make Soliton happy


Compare: https://github.com/wesnoth/wesnoth/compare/ecb72d5ec458...ef23e40d6b93