[Commits] [wesnoth/wesnoth] a2327f: Revert "Remove an unnecessary layer of indirection...

GitHub noreply at github.com
Sun Nov 12 04:37:34 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: a2327fa1993c9ce84f1cf1c3a3c442f1a4e8eca2
      https://github.com/wesnoth/wesnoth/commit/a2327fa1993c9ce84f1cf1c3a3c442f1a4e8eca2
  Author: Charles Dang <exodia339 at gmail.com>
  Date:   2017-11-12 (Sun, 12 Nov 2017)

  Changed paths:
    M src/editor/action/mouse/mouse_action.cpp
    M src/editor/action/mouse/mouse_action.hpp
    M src/editor/action/mouse/mouse_action_select.hpp
    M src/editor/toolkit/editor_toolkit.cpp

  Log Message:
  -----------
  Revert "Remove an unnecessary layer of indirection"

This reverts commit cdec9b2a7a0ea4d46231b92141ef75568411ab58. This commit broke selection of different
brushes in the Editor. Using a single pointer means changes to the brush pointer in editor_toolkit aren't
reflected in the action objects.

The double pointer isn't the cleanest code, but I'm not sure how to improve it.





More information about the Commits mailing list