[Commits] [wesnoth/wesnoth] f065b9: Stop creating invisible pseudo-haloes for [item]s

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f065b91708ace35e325e753b1c84e9b2075ba153
      https://github.com/wesnoth/wesnoth/commit/f065b91708ace35e325e753b1c84e9b2075ba153
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-12 (Sun, 12 Nov 2017)

  Changed paths:
    M src/display.cpp

  Log Message:
  -----------
  Stop creating invisible pseudo-haloes for [item]s

It makes halo code significantly easier to debug in the test scenario
when there isn't dozens of these around.


  Commit: 80d42597b8eb701e3cef40c7890fcb0bc402450e
      https://github.com/wesnoth/wesnoth/commit/80d42597b8eb701e3cef40c7890fcb0bc402450e
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-12 (Sun, 12 Nov 2017)

  Changed paths:
    M src/halo.cpp

  Log Message:
  -----------
  Remove new_haloes

New haloes were sometimes added to both new_haloes and invalidated_haloes,
and were therefore rendered twice in the same frame. As a result, the halo
added itself to its unrender buffer, and therefore remained on screen even
after unrendering.

Eliminating the entire new_haloes set fixes the issue. Fixes #2187.


Compare: https://github.com/wesnoth/wesnoth/compare/c9c0a9e76292...80d42597b8eb