[Commits] [wesnoth/wesnoth] 18e208: Revert "GUI2: removed GUI_FORCE_WIDGET_SIZE macro ...

GitHub noreply at github.com
Wed Nov 15 19:04:19 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 18e208e07c544d922d845bfadbd74192772de19a
      https://github.com/wesnoth/wesnoth/commit/18e208e07c544d922d845bfadbd74192772de19a
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M data/gui/macros/_initial.cfg
    M data/gui/window/lobby_main.cfg
    M data/gui/window/mp_join_game.cfg
    M data/gui/window/mp_staging.cfg

  Log Message:
  -----------
  Revert "GUI2: removed GUI_FORCE_WIDGET_SIZE macro in favor of fixed_width/fixed_height keys"

This reverts commit 9f386ed563e84e355130a940be804d13bf5b3d9c.

fixed_width/fixed_height are broken and completely fail to block the
widget from growing.


  Commit: 506ee85d2d72822b7c428302794e946d29ebb5e2
      https://github.com/wesnoth/wesnoth/commit/506ee85d2d72822b7c428302794e946d29ebb5e2
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M changelog
    M data/gui/schema.cfg
    M src/gui/core/window_builder.cpp
    M src/gui/core/window_builder.hpp
    M src/gui/widgets/widget.cpp
    M src/gui/widgets/widget.hpp
    M src/gui/widgets/window.hpp

  Log Message:
  -----------
  Revert "GUI2: implemented fixed_width and fixed_height keys for all widgets"

This reverts commit 556331ac3f53f2fd58fd4e137cf86af71d5c064b.

Since the keys aren't working, the implementation shouldn't be in the
Git repository. Otherwise some poor soul will attempt to use them and
face additional work afterwards.


  Commit: 7d1991a8d83cb8f34286644495351f0535c3c7d6
      https://github.com/wesnoth/wesnoth/commit/7d1991a8d83cb8f34286644495351f0535c3c7d6
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M src/gui/widgets/size_lock.cpp

  Log Message:
  -----------
  Fix #2153: crash in MP lobby chat with low horizontal window size

[size_lock] could cause layout_exception_width_modified while shrinking
the widget, and it didn't catch the exception. Now it does.


  Commit: b0c139c16a56251f1cd09a6c65cc5591f8028e58
      https://github.com/wesnoth/wesnoth/commit/b0c139c16a56251f1cd09a6c65cc5591f8028e58
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-15 (Wed, 15 Nov 2017)

  Changed paths:
    M data/gui/widget/chatbox.cfg

  Log Message:
  -----------
  Chatbox tabs can no longer shrink vertically


Compare: https://github.com/wesnoth/wesnoth/compare/84e205382f12...b0c139c16a56


More information about the Commits mailing list