[Commits] [wesnoth/wesnoth] f0fc40: Fix build with TDM-GCC

GitHub noreply at github.com
Thu Nov 16 17:34:35 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: f0fc40dc12b00e0307d50e71167123217a3f0b4e
      https://github.com/wesnoth/wesnoth/commit/f0fc40dc12b00e0307d50e71167123217a3f0b4e
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M src/filesystem_boost.cpp

  Log Message:
  -----------
  Fix build with TDM-GCC

@newfrenchy83 said that the build is failing:
https://github.com/wesnoth/wesnoth/commit/37225d24eaa52183f897e223dc3847bf89c89282#commitcomment-25629052

It looks like TDM-GCC uses Windows XP development headers, unfortunately.
However, the problem is easy to work around by simply #defining the missing
value ourselves. We should consider dropping TDM-GCC support after the 1.14
release, though.


  Commit: ec02c499c5b7408964a62433065b0beb64d0ab44
      https://github.com/wesnoth/wesnoth/commit/ec02c499c5b7408964a62433065b0beb64d0ab44
  Author: Jyrki Vesterinen <sandgtx at gmail.com>
  Date:   2017-11-16 (Thu, 16 Nov 2017)

  Changed paths:
    M src/gui/widgets/integer_selector.hpp
    M src/gui/widgets/toggle_panel.hpp

  Log Message:
  -----------
  Fix MSVC compiler warning about overriding a function

Visual Studio 2013 omits a warning if a parameter is const-qualified in the
original function but not the overriding one (or the reverse).


Compare: https://github.com/wesnoth/wesnoth/compare/b4c08f462c0f...ec02c499c5b7


More information about the Commits mailing list