[Commits] [wesnoth/wesnoth] 3d3b1b: Partially revert ca5144227707

GitHub noreply at github.com
Sun Nov 19 17:39:26 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/wesnoth/wesnoth
  Commit: 3d3b1bc443ebaee27703795e6dd83c014de911a8
      https://github.com/wesnoth/wesnoth/commit/3d3b1bc443ebaee27703795e6dd83c014de911a8
  Author: Alexander van Gessel <ai0867 at gmail.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M src/units/make.cpp
    M src/units/make.hpp

  Log Message:
  -----------
  Partially revert ca5144227707

Taking an argument, especially by reference, does not require a full type.
Including unit.hpp in make.hpp utterly defeats the point of make.hpp's existence.


  Commit: 5e575694b9a40fd385977e1c48199a8e5c0f8de7
      https://github.com/wesnoth/wesnoth/commit/5e575694b9a40fd385977e1c48199a8e5c0f8de7
  Author: Alexander van Gessel <ai0867 at gmail.com>
  Date:   2017-11-19 (Sun, 19 Nov 2017)

  Changed paths:
    M src/actions/undo_dismiss_action.hpp

  Log Message:
  -----------
  Remove unneeded include


Compare: https://github.com/wesnoth/wesnoth/compare/ca5144227707...5e575694b9a4


More information about the Commits mailing list